Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpg::Actor Add unknown 3A and 40 chunks found in DynRPG #407

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmatthew5876
Copy link
Contributor

No description provided.

@fdelapena fdelapena added this to the 0.6.3 milestone Nov 9, 2020
@fdelapena fdelapena requested a review from Ghabry March 10, 2021 03:40
@Ghabry
Copy link
Member

Ghabry commented Mar 16, 2021

btw while I was investigating the dungeon generator I'm pretty sure that I also found some unknown chunks in the code that reads the map properties:

In function 487A34 the values: 2B, 2C, 2D, 2E, 2F.

So I'm not really sure if we really want to document them all. There seem to be alot??

@fmatthew5876
Copy link
Contributor Author

I'm on the fence about this one.

If they are truly not used at all by RPG_RT, then there isn't much value in adding memory for them to our structures. That includes the chunks in this PR.

That being said, we do want to be sure the chunk IDs don't get reused for some custom feature later.

@Ghabry
Copy link
Member

Ghabry commented Mar 16, 2021

Not reusing the chunks is a valid concern. Lets keep this open longer, bet it is not hard to find even more...

fdela suggested they could be editor-only chunks (temporary data that is not saved).
But this investigating the editor which is some work...

@Ghabry Ghabry modified the milestones: 0.7.0, 0.7.1 Oct 21, 2021
@Ghabry Ghabry removed this from the 0.7.1 milestone Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants