Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lcf2xml python build #467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

seokjin1013
Copy link

Hello

I've made some modifications to enable the use of this library in Python. The build process remains unchanged, and only need to have Python installed.

I've wanted to use this library in a Firebase Python server environment, where file I/O is restricted. I think this may some helpful for someone.

import pylcf2xml
ldb = open('RPG_RT.ldb', 'rb').read()
xml = pylcf2xml.ldb2xml(ldb, encoding='949')
print(xml)

Copy link
Member

@carstene1ns carstene1ns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I like the general idea of the python binding here, the build process is not acceptable.
Need to investigate how to integrate this better.

@carstene1ns
Copy link
Member

pybind11 docs say this is a good way:

find_package(Python 3.6 COMPONENTS Interpreter Development REQUIRED)
find_package(pybind11 CONFIG REQUIRED)
pybind11_add_module(example example.cpp)

No need to use a virtual environment, just use the system package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants