Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken delete implementation #171

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Remove broken delete implementation #171

merged 2 commits into from
Dec 14, 2023

Conversation

atjn
Copy link
Collaborator

@atjn atjn commented Dec 14, 2023

The delete feature was part of an early proof-of-concept, that was always meant to be reworked. Unfortunately, editing capabilities are out of scope for our work, so the correct thing is to remove it and let the next group work with it.

Fixes #170

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for ecdar ready!

Name Link
🔨 Latest commit 7b0c598
🔍 Latest deploy log https://app.netlify.com/sites/ecdar/deploys/657afab0d063d90008a9229b
😎 Deploy Preview https://deploy-preview-171--ecdar.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@atjn atjn enabled auto-merge (squash) December 14, 2023 12:50
Copy link
Contributor

@KamyaPA KamyaPA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atjn atjn merged commit 813414a into main Dec 14, 2023
6 checks passed
@atjn atjn deleted the fix-delete-actually branch December 14, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a location is broken
3 participants