Update README.md to warn about possible network failures in call to SerialKey.Set #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a warning for network failures in the call to SerialKey.Set
eulerfx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a warning for network failures in the call to SerialKey.Set
It would be nice if the operation returned a Task rather than void to indicate that network IO is taking place. In cloud environments, there may be transient DNS issues which are handled by retry policies. I'd recommend accepting an IHttpClientFactory or making the HttpClient configurable in some other way.
Regardless, users should be aware of this potential point of failure and be prepared to apply retry policies (which make the application a lot more complicated).