Add execution logs and SealGate notification icon - #40
Open
Miyamura80 wants to merge 2 commits into
Open
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
There was a problem hiding this comment.
1 issue found across 17 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/src/main/res/drawable/ic_notification_sealgate_safe.xml">
<violation number="1" location="app/src/main/res/drawable/ic_notification_sealgate_safe.xml:1">
P3: The new ic_notification_sealgate_safe.xml copies the full ~12KB path data of ic_stat_sealgate.xml (identical 2 paths / 12,321 chars each; the only delta is the added 0.62 scale group), and this PR removes the last usage of ic_stat_sealgate from TunnelService.kt, leaving it an unreferenced resource. Reuse one source of truth instead of duplicating the giant path twice: update ic_stat_sealgate.xml in place with the scale group and point the notification builder at it (or delete ic_stat_sealgate.xml), rather than adding a parallel 13KB drawable.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a compact execution-log viewer for Mobile Bash and use the SealGate gateway mark consistently for Android notification identity.
Changes
Testing
Related Issues
None
Summary by cubic
Adds a compact execution-log viewer for Mobile Bash and uses the SealGate gateway mark for Android notification identity.
Written for commit 1e00f2a. Summary will update on new commits.