feat(cosim): optional seconds_stopped in set_agent_states - #581
Open
01Dami23 wants to merge 1 commit into
Open
Conversation
What: - Add an optional `seconds_stopped` array to c_set_agent_states (+ its binding and the Drive.set_agent_states wrapper) that injects each agent's stopped-time as external state. NULL / None keeps c_step's own per-tick accumulation. - Expose AGENT_STOPPED_SPEED_THRESHOLD to Python (mirrors MAX_SPEED / ACCEL_LONG_NORM) so co-sim callers read the threshold instead of hardcoding it. - Unit test covering both branches (NULL preserves, array overwrites). Why: - When a co-sim overwrites an agent's kinematics every tick instead of letting PufferDrive simulate it, c_step derives seconds_stopped from the dummy/injected rollout speed at env.dt, not the true external speed at the real tick rate. For CARLA/nuplan the ego is PufferDrive-simulated (only background is injected), so their ego is unaffected; a caller that injects the ego itself needs to own the field. Injecting it also removes the partner/parked-slot staleness (the existing TODO(hack)). Notes: - Backward compatible: every current caller passes no seconds_stopped (Python default None -> C NULL), so behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
seconds_stoppedarray to c_set_agent_states (+ its binding and the Drive.set_agent_states wrapper) that injects each agent's stopped-time as external state. NULL / None keeps c_step's own per-tick accumulation.seconds_stopped.Why:
Notes: