fix(sync): reuse deep URL branch cache - #453
Merged
Merged
Conversation
Deploying allagents with
|
| Latest commit: |
5fb970c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://acdb3d80.allagents.pages.dev |
| Branch Preview URL: | https://fix-skill-sync-update-hang.allagents.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/tree/<branch>/...and/blob/<branch>/...GitHub URLs when callers do not pass a branch overrideFetchOptions.branchprecedenceProblem
fetchPlugin()parsed the branch embedded in a deep GitHub URL but ignored it unless every caller also copied that branch intoFetchOptions. A standalone skill URL could therefore use the unqualified repository cache and perform a second full clone instead of reusing its existing@maincache. For the Hermes Agent repository this leftallagents updatesilent long enough to appear stuck.Verification
bun test tests/unit/core/plugin.test.ts— 17 passedbun run typecheckbun run lint— 92 files checkedbun run buildE2E
From
/home/christso/.openclaw/agent-profiles/profiles/scout:Observed exit 0 in 1.32 seconds and one
har-derived-api-clientskill synced for Copilot.Deep-URL cache-key smoke check with an isolated HOME containing only the existing branch-qualified cache:
HOME=/tmp/allagents-skill-sync-repro/home ALLAGENTS_CLONE_TIMEOUT_MS=1 bun -e "import { fetchPlugin } from './src/core/plugin.ts'; const result = await fetchPlugin('https://github.com/NousResearch/hermes-agent/blob/main/optional-skills/web-development/har-derived-api-client', { offline: true }); console.log(JSON.stringify({ action: result.action, cachePath: result.cachePath }));"Observed
action: skippedwith cache path ending inNousResearch-hermes-agent@main; no fallback clone was attempted.