Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make libMLIR_h automatically regenerate #197

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Conversation

Pangoraw
Copy link
Collaborator

No description provided.

@Pangoraw

This comment was marked as resolved.

@wsmoses
Copy link
Member

wsmoses commented Oct 25, 2024

@mofeing honestly I’m confused why the api calls weren’t here to begin with.

when these were in the Yggdrasil build it should’ve exported every symbol we built into Julia headers so that implies to be that the header rn is wrong somehow…

@Pangoraw
Copy link
Collaborator Author

so essentially replace this line:

include("libMLIR_h.jl")

with

include("path/to/Reactant_jll/libMLIR_h.jl")

?

@mofeing
Copy link
Collaborator

mofeing commented Oct 27, 2024

Wait, you should just rebuild "libMLIR_h.jl" locally in "deps/ReactantExtra/" folder by running:

bazel build //:libMLIR_h.jl

I just forgot to include that one in the make-dialects.jl script, so it regenerates automatically.

@Pangoraw
Copy link
Collaborator Author

Ok so the new make-dialects.jl should be enough ? it automatically runs on each pr ?

@Pangoraw Pangoraw changed the title Update libMLIR_h with LLVM 20 Make libMLIR_h automatically regenerate Oct 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.57%. Comparing base (b6ffc96) to head (113f244).
Report is 10 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   21.66%   25.57%   +3.90%     
==========================================
  Files          46       46              
  Lines        8048     8074      +26     
==========================================
+ Hits         1744     2065     +321     
+ Misses       6304     6009     -295     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mofeing mofeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be it. About your question, no: it doesn't run on each PR but periodically every night and by manual dispatch. If you want, you can change the workflow to run on every commit made to main but on 99% of the cases it will do nothing.

EDIT: You can add a filter to the workflow such that it automatically runs on commits that modify ReactantExtra.

EDIT-2: make-dialects.jl doesn't fit anymore. Do you mind renaming it to another thing like make-bindings.jl?

src/mlir/IR/Type.jl Outdated Show resolved Hide resolved
deps/ReactantExtra/make-dialects.jl Outdated Show resolved Hide resolved
@mofeing mofeing merged commit bccfbd7 into EnzymeAD:main Oct 27, 2024
16 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants