-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make libMLIR_h automatically regenerate #197
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
@mofeing honestly I’m confused why the api calls weren’t here to begin with. when these were in the Yggdrasil build it should’ve exported every symbol we built into Julia headers so that implies to be that the header rn is wrong somehow… |
so essentially replace this line: Line 12 in a4f685c
with include("path/to/Reactant_jll/libMLIR_h.jl") ? |
Wait, you should just rebuild "libMLIR_h.jl" locally in "deps/ReactantExtra/" folder by running:
I just forgot to include that one in the |
Ok so the new |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
+ Coverage 21.66% 25.57% +3.90%
==========================================
Files 46 46
Lines 8048 8074 +26
==========================================
+ Hits 1744 2065 +321
+ Misses 6304 6009 -295 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be it. About your question, no: it doesn't run on each PR but periodically every night and by manual dispatch. If you want, you can change the workflow to run on every commit made to main but on 99% of the cases it will do nothing.
EDIT: You can add a filter to the workflow such that it automatically runs on commits that modify ReactantExtra.
EDIT-2: make-dialects.jl
doesn't fit anymore. Do you mind renaming it to another thing like make-bindings.jl
?
No description provided.