-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework print module #394
Open
machiato32
wants to merge
24
commits into
development
Choose a base branch
from
print-module-refactor
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rework print module #394
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
676ac18
refactor
machiato32 d330b8b
remove printer role
machiato32 056fb9e
style: format code with PHP CS Fixer
deepsource-autofix[bot] e038e09
Merge remote-tracking branch 'origin/development' into print-module-r…
machiato32 3689f71
remove printer role
machiato32 74b27a2
Merge branch 'print-module-refactor' of github.com:EotvosCollegium/ma…
machiato32 9d74515
style: format code with PHP CS Fixer
deepsource-autofix[bot] 1f3dbfb
solving todos
machiato32 c8f89bd
replace exec with process->run
machiato32 781ac18
style: format code with PHP CS Fixer
deepsource-autofix[bot] 913a4a6
added missing doc strings
machiato32 6612ad8
Merge branch 'print-module-refactor' of github.com:EotvosCollegium/ma…
machiato32 7ea9be0
style: format code with PHP CS Fixer
deepsource-autofix[bot] 1930767
add missing doc comments
machiato32 26c746f
Merge branch 'print-module-refactor' of github.com:EotvosCollegium/ma…
machiato32 ead482c
style: format code with PHP CS Fixer
deepsource-autofix[bot] 31527fe
fix
machiato32 e6547cb
Merge branch 'print-module-refactor' of github.com:EotvosCollegium/ma…
machiato32 62252a9
add missing doc comment
machiato32 d8fe598
style: format code with PHP CS Fixer
deepsource-autofix[bot] 80db86f
fixes and #344
machiato32 e669bc1
Merge branch 'print-module-refactor' of github.com:EotvosCollegium/ma…
machiato32 d6fbe58
Created Process class, created PrinterHelper class, code improvements…
machiato32 1b1685c
style: format code with PHP CS Fixer
deepsource-autofix[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
{ | ||
// Use IntelliSense to learn about possible attributes. | ||
// Hover to view descriptions of existing attributes. | ||
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
"version": "0.2.0", | ||
"configurations": [ | ||
{ | ||
"name": "Listen for Xdebug", | ||
"type": "php", | ||
"request": "launch", | ||
"port": 9003 | ||
}, | ||
{ | ||
"name": "Launch currently open script", | ||
"type": "php", | ||
"request": "launch", | ||
"program": "${file}", | ||
"cwd": "${fileDirname}", | ||
"port": 0, | ||
"runtimeArgs": [ | ||
"-dxdebug.start_with_request=yes" | ||
], | ||
"env": { | ||
"XDEBUG_MODE": "debug,develop", | ||
"XDEBUG_CONFIG": "client_port=${port}" | ||
} | ||
}, | ||
{ | ||
"name": "Launch Built-in web server", | ||
"type": "php", | ||
"request": "launch", | ||
"runtimeArgs": [ | ||
"-dxdebug.mode=debug", | ||
"-dxdebug.start_with_request=yes", | ||
"-S", | ||
"localhost:0" | ||
], | ||
"program": "", | ||
"cwd": "${workspaceRoot}", | ||
"port": 9003, | ||
"serverReadyAction": { | ||
"pattern": "Development Server \\(http://localhost:([0-9]+)\\) started", | ||
"uriFormat": "http://localhost:%s", | ||
"action": "openExternally" | ||
} | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"julia.environmentPath": "c:\\Users\\sszajbely\\mars" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<?php | ||
|
||
namespace App\Enums; | ||
|
||
enum PrintJobStatus: string { | ||
case QUEUED = 'QUEUED'; | ||
case ERROR = 'ERROR'; | ||
case CANCELLED = 'CANCELLED'; | ||
case SUCCESS = 'SUCCESS'; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want these files in git?