-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing students section for general assemblies #509
Conversation
…s into missing-students-499
Passive students are also required to attend general assemblies. To make it a little less painful for the President, they are automatically excused. Their excuse can be removed if needed
Maybe I miss the point, but wouldn't it be easier to connect this with #482? That way, we would know exactly who was a collegist at that time, and from the status, we would also know whether they were active in the semester. |
You are right, my implementation stores whether they were enrolled at the time which could be done easier if #482 was fixed. |
Just took a quick look. Yes, I don't see why storing the users in a new table is necessary. We already have everything for this in the statuses. Just make a new relation between general assemblies and semesters. Anyone who is active and not excused is supposed to be there, right? |
Yes, if alumnis are never considered active. Idk, it might be the case. I was not really sure if there could be a case where alumnis / guests have an active status as previously there was a filter in the code for non-alumni collegists. But yes, it seems to be redundant. Is there a way for us to get the semester for a given date or we should store the semester for the GeneralAssembly object? |
Add a semester_id. It will fit with the new semester behaviour I'm working with. |
Closing for lack of motivation to implement the requested changes. I still think that this is a useful addition, but I don't have the time to add large changes which are outside the scope of the bug I'm trying to fix. |
Description
Added missing students section
Related Issue
#499
Changes