Fix UNSAFE_VAR_ASSIGNMENT in web-ext lint

EpocDotFr · Mar 21, 2020 · 88bb1e9 · 88bb1e9
1 parent 35d5306
commit 88bb1e9
Showing 1 changed file with 29 additions and 14 deletions.
diff --git a/js/content.js b/js/content.js
@@ -167,27 +167,42 @@
             });
         }
 
+        /**
+         * Append the given HTML string at the end of the given child target node.
+         */
+        parseHtmlAndAppendChild(targetNode, html) {
+            new DOMParser()
+                .parseFromString(html, 'text/html')
+                .querySelector('body')
+                .childNodes
+                .forEach(function(node) {
+                    targetNode.appendChild(node);
+                }
+            )
+        }
+
         /**
          * Actually updates the UI by altering the DOM by adding our stuff.
          */
         updateMergeRequestsNodes(mergeRequestsDetails) {
             let self = this;
 
             mergeRequestsDetails.forEach(function(mergeRequest) {
-                let branchesInfoNode = document.createElement('div');
-
-                branchesInfoNode.classList.add('issuable-info');
-                branchesInfoNode.innerHTML = '<span class="project-ref-path has-tooltip" title="Source branch">' +
-                        '<a class="ref-name" href="' + self.baseProjectUrl + '/-/commits/' + mergeRequest.source_branch + '">' + mergeRequest.source_branch + '</a>' +
-                    '</span>' +
-                    ' <i class="fa fa-long-arrow-right" aria-hidden="true"></i> ' +
-                    '<span class="project-ref-path has-tooltip" title="Target branch">' +
-                        '<a class="ref-name" href="' + self.baseProjectUrl + '/-/commits/' + mergeRequest.target_branch + '">' + mergeRequest.target_branch + '</a>' +
-                    '</span>';
-
-                document
-                    .querySelector('.mr-list .merge-request[data-iid="' + mergeRequest.iid + '"] .issuable-main-info')
-                    .appendChild(branchesInfoNode);
+                let infoDiv = document
+                    .querySelector('.mr-list .merge-request[data-iid="' + mergeRequest.iid + '"] .issuable-main-info');
+
+                let html = '<div class="issuable-info"><span class="project-ref-path has-tooltip" title="Source branch">' +
+                    '<a class="ref-name" href="' + self.baseProjectUrl + '/-/commits/' + mergeRequest.source_branch + '">' + mergeRequest.source_branch + '</a>' +
+                '</span>' +
+                ' <i class="fa fa-long-arrow-right" aria-hidden="true"></i> ' +
+                '<span class="project-ref-path has-tooltip" title="Target branch">' +
+                    '<a class="ref-name" href="' + self.baseProjectUrl + '/-/commits/' + mergeRequest.target_branch + '">' + mergeRequest.target_branch + '</a>' +
+                '</span></div>';
+
+                self.parseHtmlAndAppendChild(
+                    infoDiv,
+                    html
+                );
             });
         }
     }