-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test][NFC] Change from nose to pytest (web library) #3932
[test][NFC] Change from nose to pytest (web library) #3932
Conversation
cc2bdec
to
d27c67f
Compare
web/client/tests/unit/__init__.py
Outdated
sys.path.append(REPO_ROOT) | ||
sys.path.append(os.path.join(REPO_ROOT, 'web')) | ||
sys.path.append(os.path.join( | ||
REPO_ROOT, 'analyzer', 'tools', 'statistics_collector')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this tool here in a web-related makefile? The analyzer and web related parts of CodeChecker are supposed to be hermetically separated.
# --maxfail=1 | ||
|
||
# do not capture stdout | ||
--capture=fd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In analyzer tests this option was --capture=sys
. Shouldn't they match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One note, It seems that the pr contains another commit, |
d27c67f
to
3aa94a8
Compare
Continuation of #3931 and #3926.
For your convenience, I split this patch up into several parts -- in light of the previous patches, the first two commits shouldn't offer anything new.
edit: As a note, pytest doesn't support package level setup/teardown, only class level. Packages where only a single class is present, these are equivalent. This is why the 2nd commit isn't particularly exciting. :)
The 3rd one needs a little explanation:
web/tes/funtional/authentication/
:The 4th one is something I still need some fixing on. The only reason I haven't quite done it yet, because I didn't break it, it was broken already, so it feels appropriate to address it in a separate patch :)