Skip to content

Commit

Permalink
Fix minor comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sajid riaz committed Sep 9, 2024
1 parent 7413d73 commit d276530
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public RetryPolicyConfig()
private static final long DEFAULT_MAX_DELAY_IN_MS = 30000;
private static final long DEFAULT_INITIAL_DELAY_IN_MS = 86400000;
private static final long DEFAULT_FIXED_DELAY_IN_MS = 86400000;
private static final String DEFAULT_TIME_UNIT_IN_SECOND = "seconds";
private static final String DEFAULT_TIME_UNIT_IN_SECONDS = "seconds";
private RetryPolicyConfig.RetryDelay myRetryDelay = new RetryPolicyConfig.RetryDelay();
private RetryPolicyConfig.RetrySchedule myRetrySchedule = new RetryPolicyConfig.RetrySchedule();
@JsonProperty ("maxAttempts")
Expand Down Expand Up @@ -102,7 +102,7 @@ public RetryDelay()
@JsonProperty ("max")
private long myMaxDelay = DEFAULT_MAX_DELAY_IN_MS;
@JsonProperty ("unit")
private String myUnit = DEFAULT_TIME_UNIT_IN_SECOND;
private String myUnit = DEFAULT_TIME_UNIT_IN_SECONDS;

@JsonProperty ("start")
public long getStartDelay()
Expand Down Expand Up @@ -174,7 +174,7 @@ public RetrySchedule()
@JsonProperty ("fixedDelay")
private long myFixedDelay = DEFAULT_FIXED_DELAY_IN_MS;
@JsonProperty ("unit")
private String myUnit = DEFAULT_TIME_UNIT_IN_SECOND;
private String myUnit = DEFAULT_TIME_UNIT_IN_SECONDS;

@JsonProperty ("initialDelay")
public long getInitialDelay()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class TestConfig
{
private static final String DEFAULT_AGENT_FILE_NAME = "all_set.yml";
private static final String NOTHING_SET_AGENT_FILE_NAME = "nothing_set.yml";
private static final String TIME_UNIT_IN_SECOND = "seconds";
private static final String TIME_UNIT_IN_SECONDS = "seconds";
private static Config config;
private static DistributedNativeConnection nativeConnection;
private static DistributedJmxConnection distributedJmxConnection;
Expand Down Expand Up @@ -182,10 +182,10 @@ public void testRetryPolicyConfig()
assertThat(5).isEqualTo(retryPolicyConfig.getMaxAttempts());
assertThat(5000).isEqualTo(retryPolicyConfig.getRetryDelay().getStartDelay());
assertThat(30000).isEqualTo(retryPolicyConfig.getRetryDelay().getMaxDelay());
assertThat(TIME_UNIT_IN_SECOND).isEqualTo(retryPolicyConfig.getRetryDelay().getUnit());
assertThat(TIME_UNIT_IN_SECONDS).isEqualTo(retryPolicyConfig.getRetryDelay().getUnit());
assertThat(86400000).isEqualTo(retryPolicyConfig.getRetrySchedule().getInitialDelay());
assertThat(86400000).isEqualTo(retryPolicyConfig.getRetrySchedule().getFixedDelay());
assertThat(TIME_UNIT_IN_SECOND).isEqualTo(retryPolicyConfig.getRetrySchedule().getUnit());
assertThat(TIME_UNIT_IN_SECONDS).isEqualTo(retryPolicyConfig.getRetrySchedule().getUnit());
}

@Test
Expand All @@ -205,10 +205,10 @@ public void testRetryPolicyConfigWhenNothingSet() throws IOException
assertThat(5).isEqualTo(retryPolicyConfig.getMaxAttempts());
assertThat(5000).isEqualTo(retryPolicyConfig.getRetryDelay().getStartDelay());
assertThat(30000).isEqualTo(retryPolicyConfig.getRetryDelay().getMaxDelay());
assertThat(TIME_UNIT_IN_SECOND).isEqualTo(retryPolicyConfig.getRetryDelay().getUnit());
assertThat(TIME_UNIT_IN_SECONDS).isEqualTo(retryPolicyConfig.getRetryDelay().getUnit());
assertThat(86400000).isEqualTo(retryPolicyConfig.getRetrySchedule().getInitialDelay());
assertThat(86400000).isEqualTo(retryPolicyConfig.getRetrySchedule().getFixedDelay());
assertThat(TIME_UNIT_IN_SECOND).isEqualTo(retryPolicyConfig.getRetrySchedule().getUnit());
assertThat(TIME_UNIT_IN_SECONDS).isEqualTo(retryPolicyConfig.getRetrySchedule().getUnit());
}

@Test
Expand Down

0 comments on commit d276530

Please sign in to comment.