Improve hang preventing task #544 #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecChronos makes use of hang preventing task to make sure no repair tasks are hanging.
The task is scheduled to run 30 minutes after the last response on the JMX,
effectively failing the repair task.
30 minutes is a bit long time, investigate if we can make some improvements to it.
Detect that local Cassandra is down and fail the task early
Make the hang preventing task dynamic? 30 minutes is a lot of time.
SajidRiaz138
requested review from
tommystendahl,
VictorCavichioli,
jwaeab,
masokol and
ch1bbe
tommystendahl
approved these changes
Dec 12, 2023
tommystendahl
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ecChronos makes use of hang preventing task to make sure no repair tasks are hanging. The task is scheduled to run 30 minutes after the last response on the JMX, effectively failing the repair task.
30 minutes is a bit long time, investigate if we can make some improvements to it.