Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

674 Specify Interval for Next Connection #712

Merged
merged 5 commits into from
Sep 11, 2024
Merged

674 Specify Interval for Next Connection #712

merged 5 commits into from
Sep 11, 2024

Conversation

paulchandler
Copy link

Changes for #674 Specify Interval for Next Connection

@paulchandler paulchandler requested a review from a team as a code owner September 9, 2024 11:32
jwaeab
jwaeab reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@jwaeab jwaeab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, some kind of test case(s) if the config for connection delay is not set (or set properly)

application/src/main/java/com/ericsson/bss/cassandra/ecchronos/application/config/Interval.java Outdated Show resolved Hide resolved
data/src/main/java/com/ericsson/bss/cassandra/ecchronos/data/sync/EccNodesSync.java Show resolved Hide resolved
@paulchandler
Copy link
Author

Also, some kind of test case(s) if the config for connection delay is not set (or set properly)

Added a test, with a new yaml file, good catch this, as it was not working when ther connection delay was not specified

VictorCavichioli
VictorCavichioli requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@VictorCavichioli VictorCavichioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests on TestConfig that gets the values from all_set.yml

application/src/test/resources/missing_connection_delay.yml Outdated Show resolved Hide resolved
...java/com/ericsson/bss/cassandra/ecchronos/application/config/TestMissingConnectionDelay.java Outdated Show resolved Hide resolved
...java/com/ericsson/bss/cassandra/ecchronos/application/config/TestMissingConnectionDelay.java Outdated Show resolved Hide resolved
@paulchandler paulchandler reopened this Sep 10, 2024
VictorCavichioli
VictorCavichioli approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@VictorCavichioli VictorCavichioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

VictorCavichioli
VictorCavichioli requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@VictorCavichioli VictorCavichioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missing including it on CHANGES.md file

VictorCavichioli
VictorCavichioli approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@VictorCavichioli VictorCavichioli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VictorCavichioli VictorCavichioli merged commit b5178cc into Ericsson:agent/master Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwaeab jwaeab jwaeab left review comments

@SajidRiaz138 SajidRiaz138 SajidRiaz138 left review comments

@VictorCavichioli VictorCavichioli VictorCavichioli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulchandler @VictorCavichioli @jwaeab @SajidRiaz138