-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
674 Specify Interval for Next Connection #712
674 Specify Interval for Next Connection #712
Conversation
application/src/main/java/com/ericsson/bss/cassandra/ecchronos/application/config/Interval.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, some kind of test case(s) if the config for connection delay is not set (or set properly)
application/src/main/java/com/ericsson/bss/cassandra/ecchronos/application/config/Interval.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/ericsson/bss/cassandra/ecchronos/data/sync/EccNodesSync.java
Show resolved
Hide resolved
Added a test, with a new yaml file, good catch this, as it was not working when ther connection delay was not specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing tests on TestConfig that gets the values from all_set.yml
...java/com/ericsson/bss/cassandra/ecchronos/application/config/TestMissingConnectionDelay.java
Outdated
Show resolved
Hide resolved
...java/com/ericsson/bss/cassandra/ecchronos/application/config/TestMissingConnectionDelay.java
Outdated
Show resolved
Hide resolved
18af043
to
def5330
Compare
…into agent/674
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missing including it on CHANGES.md file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes for #674 Specify Interval for Next Connection