Implement RepairScheduler, Schedule Manager and Related Things #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorCavichioli
requested review from
tommystendahl,
paulchandler,
jwaeab and
SajidRiaz138
jwaeab
requested changes
Oct 15, 2024
...ava/com/ericsson/bss/cassandra/ecchronos/core/impl/repair/scheduler/RepairSchedulerImpl.java
Outdated
Show resolved
Hide resolved
...ava/com/ericsson/bss/cassandra/ecchronos/core/impl/repair/scheduler/RepairSchedulerImpl.java
Show resolved
Hide resolved
...ava/com/ericsson/bss/cassandra/ecchronos/core/impl/repair/scheduler/RepairSchedulerImpl.java
Outdated
Show resolved
Hide resolved
...ava/com/ericsson/bss/cassandra/ecchronos/core/impl/repair/scheduler/RepairSchedulerImpl.java
Outdated
Show resolved
Hide resolved
...ava/com/ericsson/bss/cassandra/ecchronos/core/impl/repair/scheduler/RepairSchedulerImpl.java
Outdated
Show resolved
Hide resolved
core.impl/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/impl/repair/RepairTask.java
Outdated
Show resolved
Hide resolved
.../com/ericsson/bss/cassandra/ecchronos/core/impl/repair/incremental/IncrementalRepairJob.java
Outdated
Show resolved
Hide resolved
.../com/ericsson/bss/cassandra/ecchronos/core/impl/repair/incremental/IncrementalRepairJob.java
Show resolved
Hide resolved
core/src/main/java/com/ericsson/bss/cassandra/ecchronos/core/state/VnodeRepairState.java
Show resolved
Hide resolved
core/src/test/java/com/ericsson/bss/cassandra/ecchronos/core/state/TestReplicaRepairGroup.java
Outdated
Show resolved
Hide resolved
jwaeab
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear reviewer,
You are probably thinking, "Why did he add so many changes at once?" and we typically avoid making so many changes in a single PR. However, I realized that it would be harder to test if I didn't include these tangential changes, and it would take longer for this to be ready. The focus is to start the application and perform repairs, but making isolated changes that don't connect seems strange, which is why there are so many changes.
Additionally, this significant change will allow much of the necessary code for upcoming tasks to already be in place, as well as progress many of our discussions. So please review with care and take the time you need.
Closes #714 #740 #738 #736 #737 #717 #722