-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agent/699 #744
base: agent/master
Are you sure you want to change the base?
Agent/699 #744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments about sections I am not sure about.
.../src/main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/NodeChangeRecord.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/NodeListComparator.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/ReloadNodesService.java
Outdated
Show resolved
Hide resolved
} | ||
catch (IOException e) | ||
{ | ||
LOG.info("Node {} JMX connection removal failed", nodeChangeRecord.getNode().getHostId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code removed now
...rc/main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/ReloadNodesService.java
Outdated
Show resolved
Hide resolved
if ((row == null) || (row.getString("value") == null)) | ||
{ | ||
simpleStatement = SimpleStatement | ||
.builder("SELECT value FROM system_views.system_properties WHERE name = 'cassandra.jmx.local.port';") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constant?
.../bss/cassandra/ecchronos/connection/impl/providers/DistributedJmxConnectionProviderImpl.java
Outdated
Show resolved
Hide resolved
.../main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/EccNodeStateListener.java
Show resolved
Hide resolved
.../main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/EccNodeStateListener.java
Outdated
Show resolved
Hide resolved
@@ -42,7 +42,7 @@ connection: | |||
- host: 127.0.0.1 | |||
port: 9042 | |||
- host: 127.0.0.2 | |||
port: 9042 | |||
port: 9043 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9042
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
1846c99
to
0d434bb
Compare
565cd83
to
8814cc5
Compare
#699 Reload nodes
First draft of the changes