Agent/699 #744
Open
Agent/699 #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulchandler
commented
Oct 14, 2024
jwaeab
reviewed
Oct 15, 2024
.../src/main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/NodeChangeRecord.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/NodeListComparator.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/ReloadNodesService.java
Outdated
Show resolved
Hide resolved
| } | ||
| catch (IOException e) | ||
| { | ||
| LOG.info("Node {} JMX connection removal failed", nodeChangeRecord.getNode().getHostId()); |
...rc/main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/ReloadNodesService.java
Outdated
Show resolved
Hide resolved
| if ((row == null) || (row.getString("value") == null)) | ||
| { | ||
| simpleStatement = SimpleStatement | ||
| .builder("SELECT value FROM system_views.system_properties WHERE name = 'cassandra.jmx.local.port';") |
.../bss/cassandra/ecchronos/connection/impl/providers/DistributedJmxConnectionProviderImpl.java
Outdated
Show resolved
Hide resolved
VictorCavichioli
requested changes
Oct 23, 2024
.../main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/EccNodeStateListener.java
Show resolved
Hide resolved
.../main/java/com/ericsson/bss/cassandra/ecchronos/application/spring/EccNodeStateListener.java
Outdated
Show resolved
Hide resolved
| @@ -42,7 +42,7 @@ connection: | |||
| - host: 127.0.0.1 | |||
| port: 9042 | |||
| - host: 127.0.0.2 | |||
| port: 9042 | |||
| port: 9043 | |||
paulchandler
force-pushed
the
agent/699
branch
from
1846c99
to
0d434bb
Compare
paulchandler
force-pushed
the
agent/699
branch
from
565cd83
to
8814cc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#699 Reload nodes
First draft of the changes