Skip to content

Commit

Permalink
[lld][WebAssembly] Update datalayout strings to latest version
Browse files Browse the repository at this point in the history
These mismatched data layouts are exposed by the refactoring in
llvm#105734 that now also
compares the non-integral pointers list of the data layout.

I dropped the explicit definition from all tests that use opt/llc since
those tools will insert the correct value, but for the llvm-as based
tests and explicit layout is required.

Reviewed By: MaskRay

Pull Request: llvm#107276
  • Loading branch information
arichardson authored Oct 25, 2024
1 parent c9b10a9 commit a35ebcf
Show file tree
Hide file tree
Showing 40 changed files with 34 additions and 40 deletions.
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/archive.ll
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define void @f() {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/cache.ll
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define i32 @_start() {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/comdat_ordering1.ll
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

; Generated from this C++ code and simplified manually:
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/comdat_ordering2.ll
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

; Generated from this C++ code and simplified manually:
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/foo.ll
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define void @foo() local_unnamed_addr {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/libcall-archive.ll
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define void @memcpy() {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/libcall-truncsfhf2.ll
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define half @__truncsfhf2(float) {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/libcall.ll
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

; This function, when compiled will generate a new undefined reference to
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/save-temps.ll
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define void @bar() {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/thin1.ll
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
; Copied from lld/test/ELF/lto/Inputs/thin1.ll

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define i32 @foo(i32 %goo) {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/thin2.ll
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
; Copied from lld/test/ELF/lto/Inputs/thin2.ll

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define i32 @blah(i32 %meh) #0 {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/thinlto.ll
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define void @g() {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/Inputs/used.ll
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

@foo = hidden global i32 1
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/archive.ll
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
; RUN: wasm-ld --export-dynamic %t2.o %t.a -o %t3
; RUN: obj2yaml %t3 | FileCheck %s

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define void @_start() {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/atomics.ll
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
; Atomic operations will not fail to compile if atomics are not
; enabled because LLVM atomics will be lowered to regular ops.

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown-wasm"

@foo = hidden global i32 1
Expand Down
1 change: 0 additions & 1 deletion lld/test/wasm/lto/cache-warnings.ll
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
; SIZE: warning: ThinLTO cache pruning happens since the total size of{{.*}}--thinlto-cache-policy
; WARN-NOT: warning: ThinLTO cache pruning happens{{.*}}--thinlto-cache-policy

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown-wasm"

define void @globalfunc() #0 {
Expand Down
1 change: 0 additions & 1 deletion lld/test/wasm/lto/cache.ll
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
; RUN: wasm-ld --thinlto-cache-dir=%t.cache --thinlto-cache-policy prune_after=0s:cache_size=0%:cache_size_files=1:prune_interval=0s -o %t.wasm %t2.o %t.o
; RUN: ls %t.cache | count 3

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown-wasm"

define void @globalfunc() #0 {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/cgo.ll
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
; ERROR-O4: wasm-ld: error: invalid optimization level for LTO: 4
; ERROR-CGO4: wasm-ld: error: invalid codegen optimization level for LTO: 4

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown-wasm"

define void @_start() {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/comdat.ll
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
; RUN: wasm-ld %t.bc %t.o -o %t.wasm
; RUN: wasm-ld %t.o %t.bc -o %t.wasm

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

$foo = comdat any
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/diagnostics.ll
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
; RUN: llvm-as %s -o %t.o
; RUN: not wasm-ld --lto-O0 %t.o -o %t2 2>&1 | FileCheck %s

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define void @_start() {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/export.ll
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
; RUN: wasm-ld --export=hidden_function -o %t.wasm %t.bc
; RUN: obj2yaml %t.wasm | FileCheck %s

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define hidden i32 @hidden_function() local_unnamed_addr {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/import-attributes.ll
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
; RUN: obj2yaml %t.wasm | FileCheck %s

target triple = "wasm32-unknown-unknown-wasm"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"

define void @_start() {
call void @foo();
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/internalize-basic.ll
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
; RUN: wasm-ld %t.o -o %t2 -save-temps
; RUN: llvm-dis < %t2.0.2.internalize.bc | FileCheck %s

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown-wasm"

define void @_start() {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/libcall-archive.ll
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
; RUN: wasm-ld -o %t %t.o %t.a
; RUN: obj2yaml %t | FileCheck %s

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define void @_start(ptr %a, ptr %b) {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/libcall-truncsfhf2.ll
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
; RUN: llvm-ar rcs %t.a %t.truncsfhf2.o
; RUN: not wasm-ld --export-all %t.o %t.a -o %t.wasm 2>&1 | FileCheck %s

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

@g_float = global float 0.0
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/lto-start.ll
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
; CHECK-NEXT: - Index: 0
; CHECK-NEXT: Name: _start

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown-wasm"

define void @_start() {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/new-pass-manager.ll
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

; CHECK: Running pass: GlobalOptPass

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define void @_start() local_unnamed_addr {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/opt-level.ll
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
; RUN: FileCheck --check-prefix=INVALIDNEGATIVE %s
; INVALIDNEGATIVE: invalid optimization level for LTO: 4294967295

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown-wasm"

; CHECK-O0: Name: foo
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/parallel.ll
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
; RUN: llvm-nm %t.lto.o | FileCheck --check-prefix=CHECK0 %s
; RUN: llvm-nm %t1.lto.o | FileCheck --check-prefix=CHECK1 %s

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown-wasm"

; CHECK0-NOT: bar
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/relocatable-undefined.ll
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
; RUN: wasm-ld -r -o %t.wasm %t.o
; RUN: obj2yaml %t.wasm | FileCheck %s

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

@missing_data = external global i32
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/relocatable.ll
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
; CHECK-NEXT: }
; CHECK-NEXT: ]

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define void @foo() {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/save-temps.ll
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
; RUN: llvm-nm a.out.lto.o | FileCheck %s
; RUN: llvm-dis a.out.0.0.preopt.bc

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define void @foo() {
Expand Down
1 change: 0 additions & 1 deletion lld/test/wasm/lto/thin-archivecollision.ll
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
; CHECK: Name: foo
; CHECK: Name: blah

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown"

define i32 @_start() #0 {
Expand Down
1 change: 0 additions & 1 deletion lld/test/wasm/lto/thinlto-thin-archive-collision.ll
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
; CHECK: thinlto-archives/thin.a(thin.o at {{[1-9][0-9]+}})
; CHECK-NEXT: -r=thinlto-archives/thin.a(thin.o at {{[1-9][0-9]+}}),blah,p

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown"

declare i32 @blah(i32 %meh)
Expand Down
1 change: 0 additions & 1 deletion lld/test/wasm/lto/thinlto.ll
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
; NM1: T f
; NM2: T g

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown"

declare void @g(...)
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/undef.ll
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
; RUN: wasm-ld %t.o -o %t.wasm --allow-undefined
; RUN: obj2yaml %t.wasm | FileCheck %s

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

declare i32 @bar()
Expand Down
1 change: 0 additions & 1 deletion lld/test/wasm/lto/used.ll
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

; Verify that symbols references from regular objects are preserved by LTO

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown"

declare void @bar()
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/verify-invalid.ll
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
; RUN: wasm-ld %t.o -o %t2 --lto-debug-pass-manager \
; RUN: -disable-verify 2>&1 | FileCheck -check-prefix=DISABLE-NPM %s

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

define void @_start() {
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/weak-undefined.ll
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
; We had a bug where stub function generation was failing because functions
; that are in bitcode (pre-LTO) don't have signatures assigned.

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

declare extern_weak i32 @foo()
Expand Down
2 changes: 1 addition & 1 deletion lld/test/wasm/lto/weak.ll
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
; RUN: wasm-ld %t.o %t.o -o %t.wasm -r
; RUN: llvm-readobj --symbols %t.wasm | FileCheck %s

target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128"
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown-wasm"

define weak void @f() {
Expand Down

0 comments on commit a35ebcf

Please sign in to comment.