Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to EPP templates #157

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Convert to EPP templates #157

merged 1 commit into from
Feb 20, 2024

Conversation

anders-larsson
Copy link
Contributor

No description provided.

@anders-larsson
Copy link
Contributor Author

Gave this code a try in real life. Zero changes to vas.conf with our configuration.

Phil-Friderici
Phil-Friderici approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@Phil-Friderici Phil-Friderici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!! I love to see you introduced arraylist.epp instead of the other four templates !!!

Looks very good to me :)

@anders-larsson
Copy link
Contributor Author

anders-larsson commented Feb 20, 2024 •
edited
Loading

Maybe it should be Array[String[1]] in the template though.

@anders-larsson
Copy link
Contributor Author

Ah. We cannot use Array[String[1]] because it fails when the API fails to return data. Leaving it as Array[String].

@anders-larsson anders-larsson merged commit 3393bc4 into Ericsson:master Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phil-Friderici Phil-Friderici Phil-Friderici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anders-larsson @Phil-Friderici