updates_for_finding_routes_for_applicance_sample #2130
+1,284
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cariashuang0417
added
documentation
cariashuang0417
requested review from
jyaistMap,
ManushiM,
nanaeaubry and
tarunkukreja003
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
View / edit / reply to this conversation on ReviewNB nanaeaubry commented on 2024-10-23T08:48:46Z The draw needs to be changed to: |
|
@cariashuang0417 Looks good for symbols but left one comment about the draw method being on |
nanaeaubry
requested changes
Oct 23, 2024
ooops forgot to change the draw() method - just updated the PR for them |
ManushiM
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I am not able to test the outputs since the original csv data is missing. For symbols, I've tested on similar point and polyline feature layers, and they works. @nanaeaubry could you check if my formatting change for symbols are in line with new mapping module standards? Thanks :)