sample notebook fighting_california_forest_fires_using_spatial_analysis.ipynb updated to incorporate the new map widget
#2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunkukreja003
requested review from
jyaistMap,
ManushiM,
nanaeaubry and
cariashuang0417
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -30,7 +30,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
Line #3. if webmap.content.layers[0].properties['name'].startswith('At_Risk_Infrastructure'):
if lyr.properties['name'].startswith('At_Risk_Infrastructure'):
Reply via ReviewNB
| @@ -30,7 +30,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
Line #4. if webmap.content.layers[0].properties['name'].startswith('At_Risk_Infrastructure'):
Same as above - if lyr.properties['name'].startswith('At_Risk_Infrastructure'):
Reply via ReviewNB
cariashuang0417
requested changes
Oct 25, 2024
nanaeaubry
reviewed
Oct 25, 2024
| @@ -30,7 +30,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
Map doesn't take zoom as a parameter. You can move this to a cell below and do m.zoom = 9
Reply via ReviewNB
| @@ -30,7 +30,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
| @@ -30,7 +30,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
| @@ -30,7 +30,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
nanaeaubry
requested changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sample notebook
fighting_california_forest_fires_using_spatial_analysis.ipynbupdated to incorporate the new map widgetplease use the playground portal account and api_data_owner account for creating the GIS object since the data is stored there