-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sample notebook fighting_california_forest_fires_using_spatial_analysis.ipynb
updated to incorporate the new map widget
#2141
base: master
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -30,7 +30,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #3. if webmap.content.layers[0].properties['name'].startswith('At_Risk_Infrastructure'):
if lyr.properties['name'].startswith('At_Risk_Infrastructure'):
Reply via ReviewNB
@@ -30,7 +30,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #4. if webmap.content.layers[0].properties['name'].startswith('At_Risk_Infrastructure'):
Same as above - if lyr.properties['name'].startswith('At_Risk_Infrastructure'):
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments for a little tweak in scripts. Overall looks good to me!
@@ -30,7 +30,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Map doesn't take zoom as a parameter. You can move this to a cell below and do m.zoom = 9
Reply via ReviewNB
@@ -30,7 +30,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -30,7 +30,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -30,7 +30,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes with zoom in the initializer
sample notebook
fighting_california_forest_fires_using_spatial_analysis.ipynb
updated to incorporate the new map widgetplease use the playground portal account and api_data_owner account for creating the GIS object since the data is stored there