Add run and event numbers to output tree. - #81
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds run/event identifiers to XGBoost output trees for alignment verification in Eventdisplay.
Changes:
- Writes
runNumberandeventNumberto stereo and classification outputs. - Adds classification provenance tracking and retains size features.
- Updates tests and changelog coverage.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/eventdisplay_ml/models.py |
Writes identifiers and changes classification grouping. |
src/eventdisplay_ml/data_processing.py |
Adds provenance tracking and classification preprocessing changes. |
src/eventdisplay_ml/features.py |
Retains classification size features. |
tests/test_regression_production_guard.py |
Tests stereo output identifiers. |
tests/test_regression_contracts.py |
Updates stereo writer contracts. |
tests/test_models_helpers.py |
Tests identifier payloads. |
tests/test_features.py |
Updates size-feature expectations. |
tests/test_data_processing_remaining.py |
Tests provenance and size retention. |
docs/changes/81.feature.md |
Documents output identifiers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows in Eventdisplay to absolutely ensure that events are aligned.