Showing only model name when removing it #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sescalada
requested changes
Dec 20, 2023
There was a problem hiding this comment.
It works well, so we could say this bug is solved :)
There are some changes that should be made, as long as I think there are things we don't need it at all:
- Just use fileName as your root Name, we don't need that auto-generated name like "Entity_".
- That sanitation method, maybe we don't need it either
src/modules/ModelViewer/Evergine.Xrv.ModelViewer/Behaviors/LoadModelBehavior.cs
Outdated
Show resolved
Hide resolved
src/modules/ModelViewer/Evergine.Xrv.ModelViewer/ModelViewerModule.cs
Outdated
Show resolved
Hide resolved
sescalada
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the remove confirmation message will show correctly the name of the model.
