Skip to content

Commit

Permalink
Use env variables to get paths to artifacts
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewGable committed Oct 25, 2024
1 parent b775cd6 commit be42ad5
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ jobs:
- name: Upload Android build to Browser Stack
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
run: curl -u "$BROWSERSTACK" -X POST "https://api-cloud.browserstack.com/app-live/upload" -F "file=@/home/runner/work/App/App/Mobile-Expensify/Android/build/outputs/bundle/release/Expensify-release.aab"
run: curl -u "$BROWSERSTACK" -X POST "https://api-cloud.browserstack.com/app-live/upload" -F "file=@${{ env.aabPath }}"
env:
BROWSERSTACK: ${{ secrets.BROWSERSTACK }}

Expand All @@ -283,7 +283,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: android-build-artifact
path: /home/runner/work/App/App/Mobile-Expensify/Android/build/outputs/bundle/release/Expensify-release.aab
path: ${{ env.aabPath }}

- name: Set current App version in Env
run: echo "VERSION=$(npm run print-version --silent)" >> "$GITHUB_ENV"
Expand Down Expand Up @@ -600,7 +600,7 @@ jobs:
- name: Upload iOS build to Browser Stack
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
run: curl -u "$BROWSERSTACK" -X POST "https://api-cloud.browserstack.com/app-live/upload" -F "file=@Expensify.ipa"
run: curl -u "$BROWSERSTACK" -X POST "https://api-cloud.browserstack.com/app-live/upload" -F "file=@${{ env.ipaPath }}"
env:
BROWSERSTACK: ${{ secrets.BROWSERSTACK }}

Expand All @@ -617,7 +617,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: ios-build-artifact
path: Expensify.ipa
path: ${{ env.ipaPath }}

# - name: Warn deployers if iOS production deploy failed
# if: ${{ failure() && fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
Expand Down

0 comments on commit be42ad5

Please sign in to comment.