Skip to content

Commit

Permalink
Fix iOS Fastlane syntax error
Browse files Browse the repository at this point in the history
  • Loading branch information
AndrewGable committed Oct 24, 2024
1 parent f4f7101 commit ce3f700
Showing 1 changed file with 34 additions and 24 deletions.
58 changes: 34 additions & 24 deletions fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -390,30 +390,6 @@ platform :ios do
}
)

desc "Upload HybridApp to TestFlight"
lane :upload_testflight do
upload_to_testflight(
api_key_path: "./ios/ios-fastlane-json-key.json",
distribute_external: true,
notify_external_testers: true,
changelog: "Thank you for beta testing New Expensify, this version includes bug fixes and improvements.",
groups: ["Beta"],
demo_account_required: true,
beta_app_review_info: {
contact_email: ENV["APPLE_CONTACT_EMAIL"],
contact_first_name: "Andrew",
contact_last_name: "Gable",
contact_phone: ENV["APPLE_CONTACT_PHONE"],
demo_account_name: ENV["APPLE_DEMO_EMAIL"],
demo_account_password: ENV["APPLE_DEMO_PASSWORD"],
notes: "1. In the Expensify app, enter the email 'appletest.expensify@proton.me'. This will trigger a sign-in link to be sent to 'appletest.expensify@proton.me'
2. Navigate to https://account.proton.me/login, log into Proton Mail using 'appletest.expensify@proton.me' as email and the password associated with 'appletest.expensify@proton.me', provided above
3. Once logged into Proton Mail, navigate to your inbox and locate the email triggered in step 1. The email subject should be 'Your magic sign-in link for Expensify'
4. Open the email and copy the 6-digit sign-in code provided within
5. Return to the Expensify app and enter the copied 6-digit code in the designated login field"
}
)

puts "dsym path: #{ENV[KEY_DSYM_PATH]}"
upload_symbols_to_crashlytics(
app_id: "1:921154746561:ios:216bd10ccc947659027c40",
Expand All @@ -423,6 +399,40 @@ platform :ios do
)
end

desc "Upload HybridApp to TestFlight"
lane :upload_testflight do
upload_to_testflight(
api_key_path: "./ios/ios-fastlane-json-key.json",
distribute_external: true,
notify_external_testers: true,
changelog: "Thank you for beta testing New Expensify, this version includes bug fixes and improvements.",
groups: ["Beta"],
demo_account_required: true,
beta_app_review_info: {
contact_email: ENV["APPLE_CONTACT_EMAIL"],
contact_first_name: "Andrew",
contact_last_name: "Gable",
contact_phone: ENV["APPLE_CONTACT_PHONE"],
demo_account_name: ENV["APPLE_DEMO_EMAIL"],
demo_account_password: ENV["APPLE_DEMO_PASSWORD"],
notes: "1. In the Expensify app, enter the email 'appletest.expensify@proton.me'. This will trigger a sign-in link to be sent to 'appletest.expensify@proton.me'
2. Navigate to https://account.proton.me/login, log into Proton Mail using 'appletest.expensify@proton.me' as email and the password associated with 'appletest.expensify@proton.me', provided above
3. Once logged into Proton Mail, navigate to your inbox and locate the email triggered in step 1. The email subject should be 'Your magic sign-in link for Expensify'
4. Open the email and copy the 6-digit sign-in code provided within
5. Return to the Expensify app and enter the copied 6-digit code in the designated login field"
}
)

# # TODO: FIX FOR HYBRIDAPP
# puts "dsym path: #{ENV[KEY_DSYM_PATH]}"
# upload_symbols_to_crashlytics(
# app_id: "1:921154746561:ios:216bd10ccc947659027c40",
# dsym_path: ENV[KEY_DSYM_PATH],
# gsp_path: "./ios/GoogleService-Info.plist",
# binary_path: "./ios/Pods/FirebaseCrashlytics/upload-symbols"
# )
end

desc "Submit app to App Store Review"
lane :submit_for_review do
deliver(
Expand Down

0 comments on commit ce3f700

Please sign in to comment.