Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Task description is covered by the keyboard pop up #50544

Merged
merged 16 commits into from
Oct 28, 2024
Merged

fix: Task description is covered by the keyboard pop up #50544

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f9e5258
fix: Task description is covered by the keyboard pop up
nkdengineer Oct 10, 2024
3fa8008
Merge branch 'main' into fix/50346
nkdengineer Oct 10, 2024
c63f60f
Merge branch 'main' into fix/50346
nkdengineer Oct 15, 2024
1e4e275
fix test
nkdengineer Oct 15, 2024
e381a1a
fix test
nkdengineer Oct 15, 2024
31ead13
Merge branch 'main' into fix/50346
nkdengineer Oct 16, 2024
8bdd1cf
fix perf-test
nkdengineer Oct 16, 2024
cccef9b
use ref for modal daat
nkdengineer Oct 16, 2024
a1803bc
Merge branch 'main' into fix/50346
nkdengineer Oct 22, 2024
ebb488e
use useOnyx
nkdengineer Oct 22, 2024
6c6a7cb
Merge branch 'main' into fix/50346
nkdengineer Oct 25, 2024
fbc69b2
revert useOnyx
nkdengineer Oct 25, 2024
9c5d4cb
fix test
nkdengineer Oct 25, 2024
d8086ab
fix lint
nkdengineer Oct 25, 2024
bc4aca8
Merge branch 'main' into fix/50346
nkdengineer Oct 25, 2024
9a36cac
use isTaskReport function
nkdengineer Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import type {
import {DeviceEventEmitter, findNodeHandle, InteractionManager, NativeModules, View} from 'react-native';
import {useFocusedInputHandler} from 'react-native-keyboard-controller';
import type {OnyxEntry} from 'react-native-onyx';
import {withOnyx} from 'react-native-onyx';
import {useOnyx, withOnyx} from 'react-native-onyx';
import {useAnimatedRef, useSharedValue} from 'react-native-reanimated';
import type {Emoji} from '@assets/emojis/types';
import type {FileObject} from '@components/AttachmentModal';
Expand Down Expand Up @@ -298,12 +298,13 @@ function ComposerWithSuggestions(
const {shouldUseNarrowLayout} = useResponsiveLayout();
const maxComposerLines = shouldUseNarrowLayout ? CONST.COMPOSER.MAX_LINES_SMALL_SCREEN : CONST.COMPOSER.MAX_LINES;

const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`);
const parentReportAction = parentReportActions?.[parentReportActionID ?? '-1'];
const shouldAutoFocus =
!modal?.isVisible &&
Modal.areAllModalsHidden() &&
isFocused &&
(shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentReportAction))) &&
(shouldFocusInputOnScreenFocus || (isEmptyChat && !ReportActionsUtils.isTransactionThread(parentReportAction) && !ReportUtils.isTaskReport(report))) &&
shouldShowComposeInput;

const valueRef = useRef(value);
Expand Down
Loading