-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Self-guided tours][V3] Add tour link to FAB #51136
base: main
Are you sure you want to change the base?
Conversation
I like that, this way it also won't compete with the green icon we use for creating a workspace from the global create menu right? |
Yeah, though there's a question of whether we should use the same treatment for that too? Actually. Let's just quickly take this to Slack before posting the final mocks here. |
PR ready with udpated styles from slack Hovered |
src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx
Outdated
Show resolved
Hide resolved
@c3024 nice find! let me fix that by adding a height |
…pover.tsx Co-authored-by: Krishna Chaitanya <102477862+c3024@users.noreply.github.com>
@c3024 fixed! |
This was for Spanish because the text is longer. |
Looks great from a visual perspective 👍 |
Reviewer Checklist
Screenshots/VideosAndroid: Nativev3Android.mp4Android: mWeb Chromev3AndroidmWeb.mp4iOS: Nativev3iOS.mp4iOS: mWeb Safariv3iOSmWeb.mp4MacOS: Chrome / Safariv3Chrome.mp4MacOS: Desktopv3Desktop.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just to confirm - does the tour open up in a new tab/new window? I think so, but just want to double check. |
New Tab |
Sweet thanks for confirming! |
Design-wise this looks good to me 👍 |
Details
Fixed Issues
$ #50926
PROPOSAL: N.A.
Tests
Admin
Other onboarding purpose
Old accounts that have not completed onboarding ever.
If a user has never completed onboarding, then they won't see the tour link in FAB.
They should see in search page tho.
Old accounts that have completed onboarding should be able to see tour link.
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Screen.Recording.2024-10-28.at.06.38.36.mov
MacOS: Chrome / Safari
Screen.Recording.2024-10-26.at.09.21.06.mov
Hovered
Without hover
MacOS: Desktop