Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat" #51289

Merged
merged 1 commit into from
Oct 22, 2024
Merged

[CP Staging] Revert "[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat" #51289

merged 1 commit into from
Oct 22, 2024

Conversation

ishpaul777
Copy link
Contributor

Reverts #49412

@blimpich blimpich marked this pull request as ready for review October 22, 2024 19:23
@blimpich blimpich requested a review from a team as a code owner October 22, 2024 19:23
@melvin-bot melvin-bot bot removed the request for review from a team October 22, 2024 19:23
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 22, 2024

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@blimpich blimpich changed the title Revert "[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat" [CP Staging] Revert "[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat" Oct 22, 2024
@blimpich blimpich mentioned this pull request Oct 22, 2024
Closed
8 tasks
@blimpich blimpich merged commit e4fb650 into Expensify:main Oct 22, 2024
14 of 18 checks passed
@melvin-bot melvin-bot bot added the Emergency label Oct 22, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 22, 2024

@blimpich looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@blimpich
Copy link
Contributor

Straight revert, not an emergency just didn't need to fill out the whole checklist since its a straight revert.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 22, 2024
OSBotify pushed a commit that referenced this pull request Oct 22, 2024
@blimpich @OSBotify
Merge pull request #51289 from ishpaul777/revert-49412-feat/49344
c19b64d 
(cherry picked from commit e4fb650)

(CP triggered by yuwenmemon)
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
Closed
74 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.0.52-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@ishpaul777 ishpaul777 mentioned this pull request Oct 23, 2024
Draft
50 tasks
@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puneetlath puneetlath puneetlath approved these changes

@blimpich blimpich blimpich approved these changes

Assignees

@ishpaul777 ishpaul777

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ishpaul777 @blimpich @OSBotify @puneetlath