Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment link for npm publish #15

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Fix comment link for npm publish #15

merged 3 commits into from
Oct 16, 2024

Conversation

AndrewGable
Copy link
Contributor

@AndrewGable AndrewGable commented Oct 16, 2024

Details

Fixes the quotes seen here: Expensify/eslint-config-expensify#133 (comment)

Related Issues

https://github.com/Expensify/Expensify/issues/432173

Manual Tests

Verified this by writing a little test on push that was confirmed here: #15 (comment)

name: Test GH API
on:
  pull_request:
    types: [opened, synchronize]
jobs:
  lint:
    if: ${{ github.actor != 'OSBotify' || github.event_name == 'workflow_call' }}
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v4
      - name: Set new version in GitHub ENV
        run: echo "NEW_VERSION=$(jq '.version' package.json)" >> $GITHUB_ENV
      - name: Set name version in GitHub ENV
        run: echo "NAME=$(jq '.name' package.json)" >> $GITHUB_ENV
      - name: Comment on PR
        run: |
          gh pr comment 15 --repo Expensify/GitHub-Actions --body ":rocket: Published in ["${{ env.NEW_VERSION }}"](https://www.npmjs.com/package/"${{ env.NAME }}"/v/"${{ env.NEW_VERSION }}") :tada:"
        env:
          GH_TOKEN: ${{ github.token }}

@AndrewGable AndrewGable self-assigned this Oct 16, 2024
Copy link

🚀 Published in 1.0.0 🎉

@luacmartins luacmartins merged commit e0ce04c into main Oct 16, 2024
1 check passed
@luacmartins luacmartins deleted the andrew-newline branch October 16, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants