9.10 fix delete #2058
Open
9.10 fix delete #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if pool nonexists, the pool update method will create a new pool. check if pool exist, before delete monitor. if the pool exists, we delete monitor directly.
if bigip partition is missing, we can not delete pool in neutron db. it is because pool has relationship with pool member and listener. when the partition is missing, member can not update(create if missing) allocate route domain in the misssing partition. when the partition is missing, listener can not update(create if missing) in the missing partition.
zhang-shengping
force-pushed
the
9.10-fix-delete
branch
from
29f5534
to
d7efa2b
Compare
zhaoqin-github
requested changes
Jun 19, 2023
| @@ -835,10 +836,12 @@ def annotate_service_members(self, service): | |||
| self.network_builder._annotate_service_route_domains(service) | |||
| except f5ex.InvalidNetworkType as exc: | |||
| LOG.warning(exc.message) | |||
| except HTTPError as err: | |||
There was a problem hiding this comment.
Does this change improve anything?
There was a problem hiding this comment.
It will throw the original HTTPError, rather cover up by f5ex.RouteDomainCreationException.
The caller will not tell what Exception happens exactly.
| try: | ||
| self.driver.annotate_service_members(service) | ||
| except HTTPError as err: | ||
| if err.response.status_code == 400: |
There was a problem hiding this comment.
Why do we need to ignore it?
There was a problem hiding this comment.
Why do we need to ignore it?
Olvan delete the whole partition, and nothing is left. When you try to annotate the route domain for members, the partition is disappeared, and the method returns 400 HTTPError. It will break the pool deleting process, it cause the pool cannot be deleted in the Neutron DB at last.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.