Build F5 dashboard package #42
Conversation
zhaoqin-github
requested review from
zhang-shengping,
zongzw and
Niklaus-xie
| #!/bin/bash | ||
|
|
||
| git checkout -- setup.cfg | ||
| rm -rf build dist *.egg *.egg-info |
There was a problem hiding this comment.
As good practice in shell, we should not suppose the current running directory is just the directory where build_rpm.sh is.
We should use the following way to get the absolute path to build_rpm.sh.
cdir=`cd $(dirname $0); pwd`
(
cd $cdir
# you logic here.
)
In that way, we can run build_rpm.sh anywhere, like ./build_rpm.sh works, /path/to/build_rpm.sh also can work..
I don't need to navigate to that folder to run the script..
| VERSION=$(rpmspec -q --qf "%{version}" f5-neutron-lbaas-dashboard.spec) | ||
|
|
||
| OLD=neutron-lbaas-dashboard-${VERSION} | ||
| NEW=f5-neutron-lbaas-dashboard-${VERSION} |
There was a problem hiding this comment.
how about using f5-openstack-dashboard, as we talked, the installed package name.
| python setup.py bdist_rpm --spec-only \ | ||
| --release=1 \ | ||
| --provides=f5-neutron-lbaas-dashboard \ | ||
| --packager="Qin Zhao <q.zhao@f5.com>" \ |
There was a problem hiding this comment.
do we have a common name instead of using personal?
|
|
||
| # Repackage source tarball | ||
|
|
||
| cd dist |
There was a problem hiding this comment.
use ( ) to start a sub shell for the work.. changing directory in shell script is not convenient when we want to add more logic, we have to glance over the whole script to see where(which directory) I'm now.
|
|
||
| /bin/cp -f f5-setup.cfg setup.cfg | ||
|
|
||
| python setup.py bdist_rpm --spec-only \ |
There was a problem hiding this comment.
what if python setup.py run failed? we may need error handling.
|
|
||
| mv ${OLD} ${NEW} | ||
|
|
||
| cd ${NEW} |
There was a problem hiding this comment.
this too.
wrap the logic into ():
(
cd $cdir
echo logic..
)
|
|
||
| rm -rf neutron_lbaas_dashboard.egg-info | ||
|
|
||
| cp -rp ../../f5_neutron_lbaas_dashboard.egg-info ./ |
There was a problem hiding this comment.
One of the benefits for using absolute path in script is when we need to debug the script with 'sh -x', it's very easy to navigate to each (called) file. Relative path is not so clear where and where.. also not convenient to debug..
|
|
||
| sed -i "s/^neutron_lbaas_dashboard/f5_neutron_lbaas_dashboard/g" f5_neutron_lbaas_dashboard.egg-info/SOURCES.txt | ||
|
|
||
| sed -i "s/_1481_project_ng_loadbalancersv2_panel.py/_1491_project_ng_loadbalancersv2_panel.py" f5_neutron_lbaas_dashboard.egg-info/SOURCES.txt |
There was a problem hiding this comment.
How about remove the empty lines and group them together..
| @@ -0,0 +1,3 @@ | |||
| mkdir -p /usr/share/openstack-dashboard/openstack_dashboard/local/enabled/ | |||
There was a problem hiding this comment.
Report error and prompt user the installation failed (exit 1) when /usr/share/openstack-dashboard not exists(openstack-dashboard is not installed yet.).
mkdir and put f5-xxxxx there is useless, cannot run either.
No description provided.