Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize reverse symmetry concept #408

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

Sheikah45
Copy link
Member

No description provided.

@Sheikah45
Copy link
Member Author

Alright @clivepaterson I think that I was able to fix the underlying issues with diag and the path function.

@clivepaterson
Copy link
Contributor

Well... I have just realized there are major updates to this branch.
So I'm 2 whiskey's in and testing it out.....
Build is broken though.... so I had to figure that out....

Totally understandable, I can only assume you have the same issues I'm getting......
image

I have, like 4 Intellij's with all sort's of different branchs/forks and crazy ideas:

(broken build):
I just had to comment out this function:
image

But once I did, I generated this map: (looks good)
image

@clivepaterson
Copy link
Contributor

clivepaterson commented Sep 17, 2024

I'm at whiskey no 3 now... and I've completed the next task,
I had a look at every commit...

Oh man, you are doing deep... lol...
I don't fully understand each line change, but I feel every line change... (It's like this repo takes you on a journey).

@Sheikah45
Copy link
Member Author

Ha yeah there also was a little bit of scope creep with some changes to the visual debugger to make it easier to verify some of the changes.

@Sheikah45
Copy link
Member Author

Also sorry on the broker build had messed up the rebase and didn't notice

@clivepaterson
Copy link
Contributor

clivepaterson commented Sep 30, 2024

So I was away for a while on a holiday, but I've tested this branch a bit.
I'm finding some unusual maps with the 1 v 1 mapgen and 3 v 3 mapgens.
Which use POINT_2 and POINT4:

Seed: 3459604215728096219
Spawns: 2
Map Size: 256
Num Teams: 2
Terrain Symmetry: POINT2

Style: DROP_PLATEAU
TerrainGenerator: DropPlateauTerrainGenerator
TextureGenerator: StonesTextureGenerator
ResourceGenerator: BasicResourceGenerator
PropGenerator: SmallBattlePropGenerator
DecalGenerator: BasicDecalGenerator
Resource Density: 0.74110866
Reclaim Density: 0.17715949
neroxis_map_generator_snapshot_gabpxncv5lb5w_aicaeaa
image

Seed: -391007914657171241
Spawns: 6
Map Size: 256
Num Teams: 2
Terrain Symmetry: POINT4

Style: LITTLE_MOUNTAIN
TerrainGenerator: LittleMountainTerrainGenerator
TextureGenerator: MarsTextureGenerator
ResourceGenerator: BasicResourceGenerator
PropGenerator: RockFieldPropGenerator
DecalGenerator: BasicDecalGenerator
Resource Density: 0.59021324
Reclaim Density: 0.7999777
neroxis_map_generator_snapshot_7kjnyx4opy4no_aycaeaq
image

I haven't dig into it much. but something happening with the perfect symmentry maps I think.

@Sheikah45
Copy link
Member Author

Interesting it looks like an angle for maybe the terrain symmetry is off. Can you add the map names here as copyable text?

@clivepaterson
Copy link
Contributor

Interesting it looks like an angle for maybe the terrain symmetry is off. Can you add the map names here as copyable text?

Yep I have updated the comment with the meta data and name. This one is also a small one, also looks good for testing:
neroxis_map_generator_snapshot_as44vgj4r6wba_aicaefa

image

I'm guessing it's prolly a small fix somewhere in the SymmetryUtil functions maybe, or one layer having issues, not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants