Don't select seasons that haven't started yet #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since when are the tests flaky? I first had one unrelated test failing, now three. Locally I had one successful run, but also a fail. |
|
They have been mildly flaky for a bit |
Sheikah45
requested changes
Sep 28, 2024
Comment on lines
71
to
73
| Optional<LeagueSeason> currentSeason = seasons.stream() | ||
| .filter(season -> season.startDate().isBefore(OffsetDateTime.now())) | ||
| .findFirst(); |
There was a problem hiding this comment.
Why are we filtering here instead of in the api call?
There was a problem hiding this comment.
Because I didn't think of doing it in the api call.
Theoretically this has the advantage that the future season is available in the picker, but I don't see any real advantage in that.
Sheikah45
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the client will select the next season as soon as it exists, even if the currently ongoing season hasn't finished yet.