Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SimUtils DrawBone function #6477

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Oct 14, 2024

Description of the proposed changes

  • 314f7ed Corrects the annotation for Entity:GetBoneDirection, as it returns the direction vector and not the roll pitch and yaw of the bone.
  • 3a99a93 Adds a DrawBone function to SimUtils which is practically identical to how the engine displays bones with ren_showskeletons.

Testing done on the proposed changes

Used the DrawBone function in a thread for a unit and made sure it is identical to the engine's version when the unit is moving around.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@lL1l1 lL1l1 added type: nice-to-have area: sim Area that is affected by the Simulation of the Game labels Oct 14, 2024
@lL1l1 lL1l1 force-pushed the annotations/fix/Entity-GetBoneDirection branch from 4f10189 to ea2e98d Compare October 23, 2024 08:00
@lL1l1 lL1l1 marked this pull request as ready for review October 23, 2024 08:00
@lL1l1
Copy link
Contributor Author

lL1l1 commented Oct 23, 2024

Not sure if VectorCross(v1, v2) or v1 * v2 is more efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: sim Area that is affected by the Simulation of the Game type: nice-to-have
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant