Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete unused files #630

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

delete unused files #630

wants to merge 3 commits into from

Conversation

sebastianbeyer
Copy link
Collaborator

I collected a few files where I thought they are not needed anymore. Please check if they are really not in use!

@sebastianbeyer
Copy link
Collaborator Author

what about test_pgierz @pgierz ? should that be moved to tests or is it not in use? (I saw in some of the logs from the CI that we run some test on ugrid compliance, I think...

@pgierz
Copy link
Member

pgierz commented Sep 25, 2024

Sorry for the late reply. If there is a unified place for test, that should go there. If I remember correctly, a ugrid compliance test is run automatically, I'll check.

@pgierz
Copy link
Member

pgierz commented Sep 25, 2024

- name: Check UGRID Compliance
run: |
pip install ugrid-checks xarray
# Needed to combine the mesh diag and output
python3 -c "import xarray as xr; ds1 = xr.open_dataset('./test/output_pi/sst.fesom.1948.nc'); ds2 = xr.open_dataset('./test/output_pi/fesom.mesh.diag.nc'); xr.merge([ds1, ds2]).to_netcdf('./test/output_pi/merged_ugrid_check.nc')"
ugrid-checker ./test/output_pi/merged_ugrid_check.nc

I'll move the text files in my test folder into the main test folder, they might be handy to keep around for reference.

@sebastianbeyer
Copy link
Collaborator Author

okay, so this is it for now I guess?

@sebastianbeyer sebastianbeyer marked this pull request as ready for review September 26, 2024 07:17
@JanStreffing
Copy link
Collaborator

OK from my side, but I would wait for Patrick. He knows better what is used / not used by FESOM core developers.

@JanStreffing JanStreffing added this to the FESOM 2.6 milestone Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants