InstCountCI: Fixes test to not use relative data #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIT code and loaded code memory offsets aren't consistent run to run which causes code generation consistency issues. Instead use a register plus an immediate that can't fit in a single 16-bit encoding to get similar register allocation to RIP relative addresses. At some point it will probably be nice to support consistent placement of both guest and host code so RIP relative can be used, but we don't have support in our backend to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIT code and loaded code memory offsets aren't consistent run to run which causes code generation consistency issues.
Instead use a register plus an immediate that can't fit in a single 16-bit encoding to get similar register allocation to RIP relative addresses.
At some point it will probably be nice to support consistent placement of both guest and host code so RIP relative can be used, but we don't have support in our backend to do that.
@alyssarosenzweig This will fix your consistency woes.