Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add cmake option DISABLE_CLANG_PRESERVE_ALL" #3409

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Revert "Add cmake option DISABLE_CLANG_PRESERVE_ALL" #3409

merged 1 commit into from
Feb 5, 2024

Conversation

neobrain
Copy link
Member

@neobrain neobrain commented Feb 5, 2024

Reverts #3394. A runtime-check for this was added in #3401.

Sonicadvance1
Sonicadvance1 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@Sonicadvance1 Sonicadvance1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably good to not create more branches on the upstream repo though.

@neobrain
Copy link
Member Author

neobrain commented Feb 5, 2024

Insta-merging since 2 more people already gave their +1 to the revert in the other PR.

@neobrain neobrain merged commit 435b67a into main Feb 5, 2024
10 checks passed
@neobrain neobrain deleted the revert-3394-PreserveAllOption branch February 5, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sonicadvance1 Sonicadvance1 Sonicadvance1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neobrain @Sonicadvance1