FEXQConfig: Add strict split-lock option #4025
Conversation
Source/Tools/FEXQonfig/main.qml
Outdated
| ConfigCheckBox { | ||
| leftPadding: 24 | ||
| text: qsTr("Strict in-process split-lock atomics") | ||
| tooltip: qsTr("Controls split-lock emulation strictness") |
There was a problem hiding this comment.
The tooltip doesn't add much. Either it should meaningfully elaborate on the feature, or it should be dropped.
There was a problem hiding this comment.
Changed the tooltip that it controls if split-locks can tear or not.
There was a problem hiding this comment.
Does it still need a tooltip if the whole text is changed to "Enable non-tearing split-lock atomics"? Not sure how critical it is to mention them being in-process, since there's no other option that it could be confused with anyway.
There was a problem hiding this comment.
Sure, removed the tooltip and changed the option name
Source/Tools/FEXQonfig/main.qml
Outdated
| @@ -603,6 +603,12 @@ ApplicationWindow { | |||
| tooltip: qsTr("Controls TSO emulation on memcpy/memset instructions") | |||
| config: "MemcpySetTSOEnabled" | |||
| } | |||
| ConfigCheckBox { | |||
| leftPadding: 24 | |||
| text: qsTr("Strict in-process split-lock atomics") | |||
There was a problem hiding this comment.
Was this intentionally positioned in the middle of the three other options? It looks rather awkward in practice. It should probably be below the other three options.
Also, could you confirm this is only used for normal TSO operation and that it is ignored for paranoid TSO?
There was a problem hiding this comment.
Actually it is independent of the these TSO toggles. Moved it below the three radio buttons since it is still part of the memory model emulation.
Sonicadvance1
force-pushed
the
split_lock_config_fexqconfig
branch
from
bb35d11
to
c68a7bf
Compare
I'm already using this a lot for testing purposes, very useful to look at the telemetry to inform if split-locks should be strict and that a crash should be verified with this option toggled. |
This was missed in the initial FEXQConfig implementation since it was implemented at the same time.
Sonicadvance1
force-pushed
the
split_lock_config_fexqconfig
branch
from
c68a7bf
to
ae545b8
Compare
This was missed in the initial FEXQConfig implementation since it was implemented at the same time.