AVX128: Fixes some AVX bugs #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
changed the title
vblendvps, vblendvpd, vpblendvb all broke because of failing to zext the 128-bit register correctly. vinsertps broke because it was accidentally using the wrong implementation. Extends each of their unittests to handle these cases.
Sonicadvance1
force-pushed
the
avx_fixes
branch
from
ae522ea
to
8b7a227
Compare
alyssarosenzweig
approved these changes
Oct 18, 2024
lioncash
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vblendvps, vblendvpd, vpblendvb all broke because of failing to zext the 128-bit register correctly.
vinsertps broke because it was accidentally using the wrong implementation.
Extends each of their unittests to handle these cases.