Fix IR operation usage to use OpSize when possible #4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase |
Sonicadvance1
force-pushed
the
fix_irsize
branch
from
606728f
to
e8baf4a
Compare
|
Rebased |
lioncash
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change.
This is a continued stride towards using OpSize enums instead of constant numbers to reduce confusion and misunderstandings.
It gets very confusing at times when an argument to an IR operation is a size versus an index, or scale or another constant. We had already cleaned up a decent amount of this early this year, late last year but this hits all the OpcodeDispatcher files in the folder. Once this is merged we can start enforcing OpSize passing to IR operations without implicit conversions. Likely will require a bit more mopping up on the edges, but should make it easier.
Just a little cleanup while I'm distracted.