Skip R2 lookup entirely for releases older than mirroring began (0.8.0) - #213
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
api | ebfb7e5 | Commit Preview URL Branch Preview URL |
Sep 01 2026, 11:01 AM |
Every fresh-fetch cycle called getReleaseR2Object() for every release,
including ones like 0.1.0 that were never uploaded to R2 and never will
be - create-release.yml's R2 upload step only runs once, at release-publish
time, and mirroring began at 0.8.0. The resulting HeadObject miss doesn't
break anything (getReleaseR2Object already returns null and the code
falls back to the GitHub URL correctly), but Cloudflare's own R2 binding
instrumentation logs every miss as an error-level span regardless of how
our code handles it - so every historical pre-0.8.0 release generates a
daily 'r2_head ERROR' log entry (once per cache refresh) forever, plus
the wasted R2 Class B operation.
Added R2_MIRROR_MIN_VERSION ('0.8.0', confirmed against when mirroring
actually began - not guessed from git history) and skip the R2 lookup
outright for any release below it, rather than issuing a HeadObject
that's guaranteed to miss.
Updated the versions/v1 README to note the cutoff. Reworked the R2
mirror test fixtures: the shared mockGitHubReleases fixture tops out at
0.6.0 (below the new cutoff, and relied on as 'latest' by unrelated
describe blocks), so the R2-mirror tests in index.test.ts and
stats/v1/index.test.ts now inject an eligible 0.8.0 release on top of it
rather than exercising the mirror path with an ineligible one. Added a
regression test proving the lookup is skipped outright (seeds the R2 key
for a pre-cutoff version and confirms it's never served, rather than
merely not finding anything).
npm run typecheck/lint/test: all clean, 533 tests pass.
admdly
force-pushed
the
fix/skip-r2-lookup-for-unmirrored-releases
branch
from
September 1, 2026 10:53
8dc3439 to
9859836
Compare
Removed mention of GitHub asset URL's IPv6 issue for clarity.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
MOCK_MIRRORED_RELEASE in versions/v1/index.test.ts and the equivalent inline literal in stats/v1/index.test.ts were byte-for-byte identical, duplicated by copy-paste when I added the R2_MIRROR_MIN_VERSION test coverage. Both files already import shared fixtures (mockGitHubReleases, mockComposerJson) from test/mocks/github-releases.ts, so moved this one there too as mockMirroredRelease - avoids the two copies drifting apart. npm run typecheck/lint/test: all clean, 533 tests pass.
Contributor
There was a problem hiding this comment.
0 issues found across 4 files (changes from recent commits).
Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
0 issues found across 3 files (changes from recent commits).
Auto-approved: Skips R2 lookups for releases older than 0.8.0 (when mirroring began), eliminating guaranteed-miss HeadObject calls and associated error logs. Adds tests and updates README; change is bounded, clearly beneficial, and matches existing behavior fallback.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getReleases()callsgetReleaseR2Object()(an R2HeadObject) for every release on every fresh-fetch cycle, including ancient releases like0.1.0that were never uploaded to R2 and never will be —create-release.yml's R2 upload step only runs once, at release-publish time, and mirroring began at 0.8.0.This doesn't break anything functionally —
getReleaseR2Object()already returnsnullon a miss and the code correctly falls back to the GitHub URL. But Cloudflare's own R2 binding instrumentation logs every miss as an error-level span regardless of how our code handles the result, e.g.:{ "error": { "message": "The specified key does not exist.", "code": 10007 }, "operation": "HeadObject", "request": { "key": "releases/0.1.0/FOSSBilling-0.1.0.zip" } }So every historical pre-0.8.0 release generates a daily
r2_head ERRORlog entry (once per cache refresh, forever), plus a wasted R2 Class B operation each time.Fix
Added
R2_MIRROR_MIN_VERSION = "0.8.0"(confirmed against when mirroring actually began, not guessed from git history) and skip the R2 lookup outright for any release below it, rather than issuing aHeadObjectthat's guaranteed to miss.Also updated the
versions/v1README to note the cutoff.