Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy-up testing examples with the F* binary package #3156

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Tidy-up testing examples with the F* binary package #3156

merged 5 commits into from
Dec 12, 2023

Conversation

tahina-pro
Copy link
Member

This PR:

  • ensures that examples can build outside of the F* directory hierarchy and with FSTAR_HOME unset. To this end, this PR moves semiring to tests/ instead, which is not tested by the F* package/release CI task.
  • disables OCaml tests for the F* binary package, since a binary package is not meant to be used for extraction of F* programs to OCaml. (Indeed, as stated in INSTALL.md, fstar.lib is not included in the binary package because it would be out of sync with users' OCaml installations, so any users who want to extract F* programs to OCaml need to use fstar.opam instead.)

@tahina-pro tahina-pro marked this pull request as draft December 12, 2023 00:38
@tahina-pro tahina-pro marked this pull request as ready for review December 12, 2023 02:56
@tahina-pro
Copy link
Member Author

Windows binary package successfully built: https://github.com/FStarLang/FStar/actions/runs/7176134260

@tahina-pro tahina-pro merged commit e2e518b into master Dec 12, 2023
3 checks passed
@tahina-pro tahina-pro deleted the _taramana_package_ci branch December 12, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tahina-pro