Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pp): char and string literals #3561

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

W95Psp
Copy link
Contributor

@W95Psp W95Psp commented Oct 14, 2024

Fixes #3560

Note: we should maybe print escape codes for certain ranges of code points 🤔

@mtzguido
Copy link
Member

Thanks Lucas, looks great, merging.

Note: we should maybe print escape codes for certain ranges of code points 🤔

To properly do this kind of thing I think the lexer should retain some information of how the char was lexed/parsed, if the user writes \n we should retain that, and the same applies for \x0a. For chars computed internally we can make some default sensible choice.

@mtzguido mtzguido merged commit ba3ae57 into FStarLang:master Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToDocument: char values are printed wrongly
2 participants