Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: Improving some errors #3590

Merged
merged 4 commits into from
Oct 23, 2024
Merged

misc: Improving some errors #3590

merged 4 commits into from
Oct 23, 2024

Commits on Oct 23, 2024

  1. Syntax/Tc: Improving error range for expected failures 

    When the set of errors do not match the expected set, we will highlight
the @@expect_failure attribute instead of the whole definition.

This works by adding a range to the Sig_fail sigelt, which is modifying
the internal AST. However, since these Sig_fail signatures never make it
to a .checked file, I don't think we need to bump the
cache_version_number.
    @mtzguido
    mtzguido committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    1f105fc View commit details
    Browse the repository at this point in the history

  2. Tc: improve some errors

    @mtzguido
    mtzguido committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    8aa6ca5 View commit details
    Browse the repository at this point in the history

  3. nit in error message

    @mtzguido
    mtzguido committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    221cacf View commit details
    Browse the repository at this point in the history

  4. snap

    @mtzguido
    mtzguido committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7392d95 View commit details
    Browse the repository at this point in the history