Skip to content

Commit

Permalink
e2e should not use jba3.0.3 until tests for 3.1 are checked
Browse files Browse the repository at this point in the history
  • Loading branch information
AhmetNSimsek authored Jul 3, 2024
1 parent 130d0df commit a27bd8f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
4 changes: 2 additions & 2 deletions e2e/features/connectivity/test_connectivity.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
for f in Cls._get_instances()
]

compound_conns = siibra.features.get(siibra.parcellations['julich 3'], RegionalConnectivity)
compound_conns = siibra.features.get(siibra.parcellations['julich 3.0.3'], RegionalConnectivity)


@pytest.mark.parametrize("cf", compound_conns)
Expand All @@ -27,7 +27,7 @@ def test_connectivity_get_data(cf: CompoundFeature):


jba_29 = siibra.parcellations["julich 2.9"]
jba_3 = siibra.parcellations["julich 3"]
jba_3 = siibra.parcellations["julich 3.0.3"]

args = [
(jba_29, "StreamlineCounts"),
Expand Down
2 changes: 1 addition & 1 deletion e2e/features/image/test_image.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
(siibra.features.get(siibra.get_template("big brain"), "CellBodyStainedVolumeOfInterest"), 2),
(siibra.features.get(siibra.get_template("mni152"), "image", restrict_space=True), 4),
(siibra.features.get(siibra.get_template("mni152"), "image", restrict_space=False), 13),
(siibra.features.get(siibra.get_region('julich 3', 'hoc1 left'), "CellbodyStainedSection"), 47),
(siibra.features.get(siibra.get_region('julich 3.1', 'hoc1 left'), "CellbodyStainedSection"), 45),
(siibra.features.get(siibra.get_region('julich 2.9', 'hoc1 left'), "CellbodyStainedSection"), 41)
]
features = [f for fts, _ in results for f in fts]
Expand Down
7 changes: 4 additions & 3 deletions e2e/volumes/test_parcellationmap.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def test_containedness(point, map: Map, query):


def test_point_assignment_to_labelled():
mp = siibra.get_map('julich 3', 'mni152')
mp = siibra.get_map('julich 3.0.3', 'mni152')
# certain point
point = siibra.Point((25.5, -26.0, 72.0), space='mni152')
assignments = mp.assign(point)
Expand Down Expand Up @@ -123,9 +123,10 @@ def test_fetching_merged_volume():
_ = mp.fetch()


# TODO: add tests for jba 3.1
@pytest.mark.parametrize("siibramap", [
siibra.get_map('julich 3', 'fsaverage'),
siibra.get_map('julich 3', 'mni152'),
siibra.get_map('julich 3.0.3', 'fsaverage'),
siibra.get_map('julich 3.0.3', 'mni152'),
])
def test_fetching_mask(siibramap: Map):
for fmt in siibramap.formats:
Expand Down

0 comments on commit a27bd8f

Please sign in to comment.