-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bbox planar intersection #609
base: main
Are you sure you want to change the base?
Conversation
This PR fixes the no intersection issue when the intersection of 2 bounding boxes is planar and hence have volume 0 resulting in None. This meant that while there are some intersections, these were ignored. Also, the edge case, the intersection is just a point, is accounted for.
LGTM, but you should check with @dickscheid to see if volume check is important. remind me, This issue does not affect siibra python v2, since there is no volume check. |
There is a conversation about it here. I thought I remembered all the details but I will make some adjustments to this PR based on Timo's comment.
Yes by default it is false, i.e., compares anchors across different spaces.
True |
…NaN or in between unsupported spaces
…arpingFailedError` not `ValueError`
This PR fixes the no intersection issue when the intersection of 2 bounding boxes is planar and hence have volume 0 resulting in None. This meant that while there are some intersections, these were ignored. Also, the edge case, the intersection is just a point, is accounted for.
code to reproduce the issue on current main