Fix for case when table joins, although created by their "logical" order have wrong order in final queries #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der, have wrong order in final queries Actually it would make more sense if we create a feature of reordering joins. example of issue from one to two from two to three from three to four from four to five it could produce joins in this order left join two on two.one_id= one.id left join three on three.two_id= two.id left join five on five.four_id = four.id left join four on four.three_id = three.id and error message which says that there is no four.id in field list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually it would make more sense if we also create a feature of reordering joins.
example of issue
from one to two
from two to three
from three to four
from four to five
it could produce joins in this order:
left join two on two.one_id= one.id
left join three on three.two_id= two.id
left join five on five.four_id = four.id
left join four on four.three_id = three.id
and error message which says that there is no four.id in field list