Modify install to get arm64 packages when appropriate #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
han-so1omon
requested review from
sudermanjr and
TheCubicleJockey
as code owners
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7
Checklist
Description
What's the goal of this PR?
Allow asdf-crictl to install arm64 package versions as appropriate
What changes did you make?
Changed hardcoded path to amd64 package to register if on amd/intel 64bit or arm 64bit platform
What alternative solution should we consider, if any?
The structure of the
bin/install/get_platform_code()function may not be as clean as it could be. Possibly update that