Bumped version v1.3.2

FaustVX · Nov 19, 2023 · 4a05260 · 4a05260
1 parent 48a29ca
commit 4a05260
Show file tree

Hide file tree

Showing 18 changed files with 91 additions and 39 deletions.
diff --git a/ConsoleApp1/ConsoleApp1.csproj b/ConsoleApp1/ConsoleApp1.csproj
@@ -19,7 +19,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="FaustVX.PrimaryParameter.SG" Version="1.3.1" />
+    <PackageReference Include="FaustVX.PrimaryParameter.SG" Version="1.3.2" />
     <!-- <ProjectReference Include="..\PrimaryParameter.SG\PrimaryParameter.SG.csproj" OutputItemType="Analyzer" ReferenceOutputAssembly="false" PrivateAssets="All" /> -->
   </ItemGroup>
 

diff --git a/PrimaryParameter.SG/Generator.cs b/PrimaryParameter.SG/Generator.cs
@@ -381,7 +381,15 @@ static IEnumerable<Parameter> GetTypesToGenerate(Compilation compilation, IEnume
     }
 
     static void GenerateFiles(IEnumerable<Parameter> parameters, SourceProductionContext context)
-        => context.AddSource("FaustVX.PrimaryParameter.SG.g.cs", string.Concat(parameters.Select(static item => GetResource(item.Namespace, item.TypeName, item.FieldNames.Select(n => n.GenerateMember(item))))));
+    {
+        context.AddSource("FaustVX.PrimaryParameter.SG.g.cs", string.Concat(parameters.Where(Where).Select(Select)));
+
+        static bool Where(Parameter parameter)
+            => parameter.FieldNames.Length > 0;
+
+        static string Select(Parameter parameter)
+            => GetResource(parameter.Namespace, parameter.TypeName, parameter.FieldNames.Select(n => n.GenerateMember(parameter)));
+    }
 
     static string GetResource(string nameSpace, ParentClass? parentClass, IEnumerable<string> inner)
     {

diff --git a/PrimaryParameter.SG/PrimaryParameter.SG.csproj b/PrimaryParameter.SG/PrimaryParameter.SG.csproj
@@ -31,7 +31,7 @@
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
     <PackageId>FaustVX.PrimaryParameter.SG</PackageId>
-    <Version>1.3.1</Version>
+    <Version>1.3.2</Version>
     <Authors>FaustVX</Authors>
     <RepositoryUrl>https://github.com/FaustVX/PrimaryParameter</RepositoryUrl>
     <RepositoryType>git</RepositoryType>

diff --git a/PrimaryParameter.Tests/PrimaryParameterSnapshotTests.cs b/PrimaryParameter.Tests/PrimaryParameterSnapshotTests.cs
@@ -147,7 +147,7 @@ public Task GeneratesPC01WithDontUse()
         // The source code to test
         var source = """
             using PrimaryParameter.SG;
-            public partial class C([DontUse] int i)
+            public class C([DontUse] int i)
             {
                 int M() => i;
             }
@@ -163,7 +163,7 @@ public Task DontGeneratesPC01WithDontUseOnMember_Simple()
         // The source code to test
         var source = """
             using PrimaryParameter.SG;
-            public partial class C([DontUse(AllowInMemberInit = true)] int i)
+            public class C([DontUse(AllowInMemberInit = true)] int i)
             {
                 int M = i;
             }
@@ -179,7 +179,7 @@ public Task DontGeneratesPC01WithDontUseOnMember_Complex()
         // The source code to test
         var source = """
             using PrimaryParameter.SG;
-            public partial class C([DontUse(AllowInMemberInit = true)] int i)
+            public class C([DontUse(AllowInMemberInit = true)] int i)
             {
                 string L = i.ToString();
             }
@@ -195,7 +195,7 @@ public Task DontGeneratesPC01WithDontUseOnPropertyInitializer()
         // The source code to test
         var source = """
             using PrimaryParameter.SG;
-            public partial class C([DontUse(AllowInMemberInit = true)] int i)
+            public class C([DontUse(AllowInMemberInit = true)] int i)
             {
                 string L { get; } = i.ToString();
             }
@@ -211,7 +211,7 @@ public Task DoGeneratesPC01WithDontUseOnPropertyBody()
         // The source code to test
         var source = """
             using PrimaryParameter.SG;
-            public partial class C([DontUse] int i)
+            public class C([DontUse] int i)
             {
                 int M => i;
             }
@@ -227,7 +227,7 @@ public Task DoGeneratesPC01WithDontUseOnPropertyGet()
         // The source code to test
         var source = """
             using PrimaryParameter.SG;
-            public partial class C([DontUse] int i)
+            public class C([DontUse] int i)
             {
                 int M
                 {
@@ -246,7 +246,7 @@ public Task DoGeneratesPC01WithDontUseOnMember()
         // The source code to test
         var source = """
             using PrimaryParameter.SG;
-            public partial class C([DontUse(AllowInMemberInit = false)] int i)
+            public class C([DontUse(AllowInMemberInit = false)] int i)
             {
                 int M = i;
             }
@@ -255,4 +255,18 @@ public partial class C([DontUse(AllowInMemberInit = false)] int i)
         // Pass the source code to our helper and snapshot test the output
         return TestHelper.Verify(source);
     }
+
+    [Fact]
+    public Task DontNeedPartialModifierOnType()
+    {
+        // The source code to test
+        var source = """
+            using PrimaryParameter.SG;
+            public class C([DontUse] int i)
+            { }
+            """;
+
+        // Pass the source code to our helper and snapshot test the output
+        return TestHelper.Verify(source);
+    }
 }
diff --git a/...napshotTests.DoGeneratesPC01WithDontUseOnMember/FaustVX.PrimaryParameter.SG.g.verified.cs b/...napshotTests.DoGeneratesPC01WithDontUseOnMember/FaustVX.PrimaryParameter.SG.g.verified.cs
@@ -1,5 +1 @@
 //HintName: FaustVX.PrimaryParameter.SG.g.cs
-// <auto-generated/>
-partial class C
-{
-}
diff --git a/...tTests.DoGeneratesPC01WithDontUseOnPropertyBody/FaustVX.PrimaryParameter.SG.g.verified.cs b/...tTests.DoGeneratesPC01WithDontUseOnPropertyBody/FaustVX.PrimaryParameter.SG.g.verified.cs
@@ -1,5 +1 @@
 //HintName: FaustVX.PrimaryParameter.SG.g.cs
-// <auto-generated/>
-partial class C
-{
-}
diff --git a/...otTests.DoGeneratesPC01WithDontUseOnPropertyGet/FaustVX.PrimaryParameter.SG.g.verified.cs b/...otTests.DoGeneratesPC01WithDontUseOnPropertyGet/FaustVX.PrimaryParameter.SG.g.verified.cs
@@ -1,5 +1 @@
 //HintName: FaustVX.PrimaryParameter.SG.g.cs
-// <auto-generated/>
-partial class C
-{
-}
diff --git a/...ts.DontGeneratesPC01WithDontUseOnMember_Complex/FaustVX.PrimaryParameter.SG.g.verified.cs b/...ts.DontGeneratesPC01WithDontUseOnMember_Complex/FaustVX.PrimaryParameter.SG.g.verified.cs
@@ -1,5 +1 @@
 //HintName: FaustVX.PrimaryParameter.SG.g.cs
-// <auto-generated/>
-partial class C
-{
-}
diff --git a/...sts.DontGeneratesPC01WithDontUseOnMember_Simple/FaustVX.PrimaryParameter.SG.g.verified.cs b/...sts.DontGeneratesPC01WithDontUseOnMember_Simple/FaustVX.PrimaryParameter.SG.g.verified.cs
@@ -1,5 +1 @@
 //HintName: FaustVX.PrimaryParameter.SG.g.cs
-// <auto-generated/>
-partial class C
-{
-}
diff --git a/...ntGeneratesPC01WithDontUseOnPropertyInitializer/FaustVX.PrimaryParameter.SG.g.verified.cs b/...ntGeneratesPC01WithDontUseOnPropertyInitializer/FaustVX.PrimaryParameter.SG.g.verified.cs
@@ -1,5 +1 @@
 //HintName: FaustVX.PrimaryParameter.SG.g.cs
-// <auto-generated/>
-partial class C
-{
-}
diff --git a/...rimaryParameterSnapshotTests.DontNeedPartialModifierOnType/DontUseAttribute.g.verified.cs b/...rimaryParameterSnapshotTests.DontNeedPartialModifierOnType/DontUseAttribute.g.verified.cs
@@ -0,0 +1,11 @@
+//HintName: DontUseAttribute.g.cs
+// <auto-generated/>
+using global::System;
+namespace PrimaryParameter.SG
+{
+    [AttributeUsage(AttributeTargets.Parameter, Inherited = false, AllowMultiple = false)]
+    sealed class DontUseAttribute : Attribute
+    {
+        public bool AllowInMemberInit { get; init; }
+    }
+}
diff --git a/...eterSnapshotTests.DontNeedPartialModifierOnType/FaustVX.PrimaryParameter.SG.g.verified.cs b/...eterSnapshotTests.DontNeedPartialModifierOnType/FaustVX.PrimaryParameter.SG.g.verified.cs
@@ -0,0 +1 @@
+//HintName: FaustVX.PrimaryParameter.SG.g.cs
diff --git a/.../PrimaryParameterSnapshotTests.DontNeedPartialModifierOnType/FieldAttribute.g.verified.cs b/.../PrimaryParameterSnapshotTests.DontNeedPartialModifierOnType/FieldAttribute.g.verified.cs
@@ -0,0 +1,15 @@
+//HintName: FieldAttribute.g.cs
+// <auto-generated/>
+using global::System;
+namespace PrimaryParameter.SG
+{
+    [AttributeUsage(AttributeTargets.Parameter, Inherited = false, AllowMultiple = true)]
+    sealed class FieldAttribute : Attribute
+    {
+        public string Name { get; init; }
+        public string AssignFormat { get; init; }
+        public Type Type { get; init; }
+        public bool IsReadonly { get; init; }
+        public string Scope { get; init; }
+    }
+}
diff --git a/...imaryParameterSnapshotTests.DontNeedPartialModifierOnType/PropertyAttribute.g.verified.cs b/...imaryParameterSnapshotTests.DontNeedPartialModifierOnType/PropertyAttribute.g.verified.cs
@@ -0,0 +1,15 @@
+//HintName: PropertyAttribute.g.cs
+// <auto-generated/>
+using global::System;
+namespace PrimaryParameter.SG
+{
+    [AttributeUsage(AttributeTargets.Parameter, Inherited = false, AllowMultiple = true)]
+    sealed class PropertyAttribute : Attribute
+    {
+        public string Name { get; init; }
+        public string AssignFormat { get; init; }
+        public Type Type { get; init; }
+        public string Setter { get; init; }
+        public string Scope { get; init; }
+    }
+}
diff --git a/...imaryParameterSnapshotTests.DontNeedPartialModifierOnType/RefFieldAttribute.g.verified.cs b/...imaryParameterSnapshotTests.DontNeedPartialModifierOnType/RefFieldAttribute.g.verified.cs
@@ -0,0 +1,14 @@
+//HintName: RefFieldAttribute.g.cs
+// <auto-generated/>
+using global::System;
+namespace PrimaryParameter.SG
+{
+    [AttributeUsage(AttributeTargets.Parameter, Inherited = false, AllowMultiple = true)]
+    sealed class RefFieldAttribute : Attribute
+    {
+        public string Name { get; init; }
+        public string Scope { get; init; }
+        public bool IsReadonlyRef { get; init; }
+        public bool IsRefReadonly { get; init; }
+    }
+}
diff --git a/...ParameterSnapshotTests.GeneratesPC01WithDontUse/FaustVX.PrimaryParameter.SG.g.verified.cs b/...ParameterSnapshotTests.GeneratesPC01WithDontUse/FaustVX.PrimaryParameter.SG.g.verified.cs
@@ -1,5 +1 @@
 //HintName: FaustVX.PrimaryParameter.SG.g.cs
-// <auto-generated/>
-partial class C
-{
-}
diff --git a/README.md b/README.md
@@ -95,7 +95,8 @@ You can type as many attributes as you want on a single parameter (Except for `D
 ## Versions
 |Version|Date|Comments|
 |-------|----|--------|
-|v1.3.1|25/08/2023|fix a bug with member initialization|
+|v1.3.2|19/11/2023|Don't generate the partial generated type if not needed|
+|v1.3.1|19/11/2023|Fix a bug with member initialization|
 |v1.3.0|19/11/2023|Added `DontUseAttribute`<br/>Add a code-fix for `CS0282`<br/>Changed `PropertyAttribute.WithInit` to `PropertyAttribute.Setter`|
 |v1.2.0|25/08/2023|Support for default values customization|
 |v1.1.0|15/08/2023|[dotnet/roslyn#67371](https://github.com/dotnet/roslyn/issues/67371) fixed<br/>(related to `v0.4.6`)|

diff --git a/TODO.md b/TODO.md
@@ -10,3 +10,4 @@
 		- `set`
 		- `init`
 - [x] Add `// <auto-generated/>` in `FaustVX.PrimaryParameter.SG.g.cs`
+- [x] Don't generate empty partial types