Feature 1.13 llm update #5063
Merged
Feature 1.13 llm update #5063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: weijingchen <talkingwallace@sohu.com>
support ipr fix typo Signed-off-by: weijingchen <talkingwallace@sohu.com>
1. Update homonn framework, support arbiter side model 2. Fix bug & log format 3. Update aggregator framework Signed-off-by: weijingchen <talkingwallace@sohu.com>
Signed-off-by: weijingchen <talkingwallace@sohu.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
103
to
104
| self._updated = {'trainer': False, 'dataset': False, | ||
| 'torch_seed': False, 'loss': False, 'optimizer': False, 'model': False} | ||
| 'torch_seed': False, 'loss': False, 'optimizer': False, 'model': False, 'ds_config': False, 'server_init': False} |
There was a problem hiding this comment.
[autopep8] reported by reviewdog 🐶
Suggested change
| self._updated = {'trainer': False, 'dataset': False, | |
| 'torch_seed': False, 'loss': False, 'optimizer': False, 'model': False} | |
| 'torch_seed': False, 'loss': False, 'optimizer': False, 'model': False, 'ds_config': False, 'server_init': False} | |
| self._updated = { | |
| 'trainer': False, | |
| 'dataset': False, | |
| 'torch_seed': False, | |
| 'loss': False, | |
| 'optimizer': False, | |
| 'model': False, | |
| 'ds_config': False, | |
| 'server_init': False} |
|
|
||
| def __init__(self) -> None: | ||
| super().__init__() | ||
|
|
There was a problem hiding this comment.
[autopep8] reported by reviewdog 🐶
Suggested change
| @property | ||
| def embeded_param(self): | ||
| return None | ||
|
|
There was a problem hiding this comment.
[autopep8] reported by reviewdog 🐶
Suggested change
|
|
||
| """ | ||
| Recursively replaces the LayerNorm layers of a given module with SignatureLayerNorm layers. | ||
|
|
There was a problem hiding this comment.
[autopep8] reported by reviewdog 🐶
Suggested change
| layer_name_set (set[str], optional): A set of layer names to be replaced. If None, | ||
| all LayerNorm layers in the module will be replaced. | ||
| """ | ||
|
|
There was a problem hiding this comment.
[autopep8] reported by reviewdog 🐶
Suggested change
| @property | ||
| def embeded_param(self): | ||
| return self.ln.weight | ||
|
|
There was a problem hiding this comment.
[autopep8] reported by reviewdog 🐶
Suggested change
| return self.ln.weight | ||
|
|
||
| def embeded_param_num(self): | ||
| return self._embed_param_num |
There was a problem hiding this comment.
[autopep8] reported by reviewdog 🐶
Suggested change
| return self._embed_param_num | |
| return self._embed_param_num |
| conv = SignatureConv(3, 384, 3, 1, 1) | ||
| layer_norm = SignatureLayerNorm((768, )) | ||
| layer_norm_2 = SignatureLayerNorm.from_layer_norm_layer(layer_norm.ln) | ||
|
|
There was a problem hiding this comment.
[autopep8] reported by reviewdog 🐶
Suggested change
Signed-off-by: weijingchen <talkingwallace@sohu.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Chen <cwjghglbdcj@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Chen <cwjghglbdcj@gmail.com>
| @@ -82,7 +86,9 @@ def __init__(self, | |||
| loss=None, | |||
| optimizer: OptimizerType = None, | |||
| ds_config: dict = None, | |||
| model: Sequential = None, **kwargs): | |||
| model: Sequential = None, | |||
There was a problem hiding this comment.
[autopep8] reported by reviewdog 🐶
Suggested change
| model: Sequential = None, | |
| model: Sequential = None, |
Signed-off-by: weijingchen <talkingwallace@sohu.com>
mgqa34
approved these changes
Aug 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for FATE-LLM 1.3:
update nn framework
fix log & bug in nn